Lucas_Werkmeister_WMDE created this task. Lucas_Werkmeister_WMDE added projects: Wikidata, wdwb-tech-focus, Sustainability (Incident Followup). Restricted Application added a subscriber: Aklapper.
TASK DESCRIPTION The `EntityContentFactory` class, in addition to providing content-related methods like `getContentHandlerForType()` and `newFromEntity()`, also implements the `EntityTitleStoreLookup` interface. However, directly using an `EntityContentFactory` instance as an `EntityTitleStoreLookup` or `EntityTitleLookup` is incorrect: doing so was the cause of T269603 <https://phabricator.wikimedia.org/T269603> (see the commit message of the bugfix <https://gerrit.wikimedia.org/r/c/mediawiki/extensions/Wikibase/+/657550/> for details). To avoid repeating this mistake in the future, I propose we change `EntityContentFactory` so it no longer implements `EntityTitleStoreLookup`, and instead create a new class that implements that interface by //wrapping// an `EntityContentFactory`. (Or we could merge that functionality into the existing `TypeDispatchingEntityTitleStoreLookup` class?) Furthermore, we should do the same thing for the `EntityIdLookup` interface, which `EntityContentFactory` also implements (though in that case there’s currently no difference between `WikibaseRepo`’s `getEntityIdLookup()` and `getEntityContentFactory()`). TASK DETAIL https://phabricator.wikimedia.org/T276439 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Lucas_Werkmeister_WMDE Cc: Lucas_Werkmeister_WMDE, Aklapper, Akuckartz, Nandana, jijiki, Klaas_Z4us_V, Lahi, Gq86, GoranSMilovanovic, QZanden, LawExplorer, elukey, _jensen, rosalieper, Scott_WUaS, abian, Wikidata-bugs, aude, Addshore, Mbch331, Jay8g
_______________________________________________ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
