Addshore added a comment.
So the top level of dispatching happens in https://github.com/wikimedia/Wikibase/blob/4eefb25d289d928f81230f306570a1a575a7ceba/data-access/src/MultipleEntitySourceServices.php#L95-L108 This currently gets a PrefetchingTermLookup for the whole entity source, rather than for a specific entity type from the entity source. It appears this is why things get wrapped twice. Although appearing a bit odd this should end up doing the right thing and shouldn't have much overhead. A "fix" would be to modify https://github.com/wikimedia/Wikibase/blob/4eefb25d289d928f81230f306570a1a575a7ceba/data-access/src/SingleEntitySourceServices.php#L346-L377 / `SingleEntitySourceServices` to allow retrieval of services like this specific to one of the entity types that they are the source for. TASK DETAIL https://phabricator.wikimedia.org/T277737 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Addshore Cc: Addshore, Aklapper, ItamarWMDE, maantietaja, Akuckartz, Nandana, Lahi, Gq86, GoranSMilovanovic, QZanden, LawExplorer, _jensen, rosalieper, Scott_WUaS, abian, Wikidata-bugs, aude, Mbch331
_______________________________________________ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
