Krinkle added a comment.
In T279408#6975664 <https://phabricator.wikimedia.org/T279408#6975664>, @Lucas_Werkmeister_WMDE wrote: > Error happens here: > > public function formatResult( $skin, $result ) { > $title = $this->titleFactory->newFromID( $result->value ); > $out = $this->getLinkRenderer()->makeKnownLink( $title ); > // ... > } > > Looks like a result page went away between the query and formatting the result… not sure how to handle this. Seems like something that `QueryPage` subclasses might have to deal with in general, so probably worth looking at some other classes. They do, and they have. Fetching titles at runtime for each result is not something we typically do in such case since that's upto 500 or 5000 db roundtrip queries the page would have to perform (depending on user rights). We usually use a join and LinkCache for this. The UI rendering is typically strike-through, or if there's not enough information for a link, omit. TASK DETAIL https://phabricator.wikimedia.org/T279408 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Krinkle Cc: Krinkle, Lucas_Werkmeister_WMDE, Addshore, Aklapper, Michael, Invadibot, maantietaja, Akuckartz, Iflorez, darthmon_wmde, alaa_wmde, Nandana, Lahi, Gq86, GoranSMilovanovic, QZanden, LawExplorer, _jensen, rosalieper, Scott_WUaS, Jonas, Verdy_p, Wikidata-bugs, aude, Lydia_Pintscher, Jdforrester-WMF, Mbch331, Jay8g
_______________________________________________ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
