Ladsgroup added a comment.
Oh this is another case of catching DBErrors. See https://www.mediawiki.org/wiki/Database_transactions#Use_of_transaction_rollback (emphasis not mine) > Callers might catch DBError exceptions without either re-throwing them or throwing their own version of the error. Doing so is extremely **bad practice** and can cause all sorts of problems from partial commits to simply spewing up DBTransactionError errors. Only catch DB errors in order to do some cleanup before re-throwing an error or if the database in question is used **exclusively** by the code catching errors. Funnily enough, we don't catch any db error in our codebase (the only one we catch is never thrown, removing that for good measure), it's happening in core meaning this warning will likely continue to pop up in different shape and form for different extensions or basically anything that does sql queries in deferred updates. TASK DETAIL https://phabricator.wikimedia.org/T279409 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Ladsgroup Cc: Ladsgroup, Jakob_WMDE, Addshore, Aklapper, Lucas_Werkmeister_WMDE, Michael, Invadibot, maantietaja, Alter-paule, Beast1978, Un1tY, Akuckartz, Hook696, Iflorez, darthmon_wmde, Kent7301, alaa_wmde, joker88john, CucyNoiD, Nandana, Gaboe420, Giuliamocci, Cpaulf30, Lahi, Gq86, Af420, Bsandipan, GoranSMilovanovic, QZanden, LawExplorer, Lewizho99, Maathavan, _jensen, rosalieper, Scott_WUaS, Jonas, Verdy_p, Wikidata-bugs, aude, Lydia_Pintscher, Jdforrester-WMF, Mbch331, Jay8g
_______________________________________________ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
