guergana.tzatchkova added a comment.

  In T277646#6997745 <https://phabricator.wikimedia.org/T277646#6997745>, 
@Addshore wrote:
  
  > This was picked up in storytime for camp with the estimation removed.
  > In the TODO column for now as the state in story time was not known (should 
this be in doing or review etc?)
  > Waiting for @guergana.tzatchkova etc to be back :)
  
  The patch should be merged since it's getting too big.
  
  I would suggest either adding subsequent patches after the current one is 
made. 
  Or breaking down into the remaining tasks:
  
  - Fixing the optionals for unions (conditions joined by OR) when there are 
more than two conditions.
  - Adusting the variable names when there are two columns with the same 
property. Right now they are indexed by property index, (if we have three 
conditions, with one repeating it would be something like `P17_0`, `P281_1`, 
`P17_2`) but in some(?) cases they need to be unified to have the same variable 
name, like `P17_0` (would serve `P17_0 and P17_2`) , `P281_1`

TASK DETAIL
  https://phabricator.wikimedia.org/T277646

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: guergana.tzatchkova
Cc: Addshore, Lucas_Werkmeister_WMDE, Aklapper, Lydia_Pintscher, Invadibot, 
maantietaja, Alter-paule, Beast1978, Un1tY, Akuckartz, Hook696, Iflorez, 
Kent7301, alaa_wmde, joker88john, CucyNoiD, Nandana, Gaboe420, Giuliamocci, 
Cpaulf30, Lahi, Gq86, Af420, Bsandipan, GoranSMilovanovic, QZanden, 
LawExplorer, Lewizho99, Maathavan, _jensen, rosalieper, Scott_WUaS, Jonas, 
Wikidata-bugs, aude, Mbch331
_______________________________________________
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

Reply via email to