Addshore added a comment.
I couldn't resist poking @daniel with the findings. > 9:34 PM <duesen> I'm trying to remember whether saving the wikidata page would add subscriptions for all sites that have sitelinks. > 9:35 PM <addshore> onParserCacheSaveComplete > 9:36 PM <addshore> another possibility is that we used to dispatch to all sites that had sitelinks or something? > 9:36 PM <duesen> I think we forced dispatching to the site that was just added, if the event was "add a sitelink". We went digging around and found exactly what daniel was referring to > 9:44 PM <addshore> So that code path depends on this change being an `ItemChange` and i dont see where that is made right now > 9:45 PM <duesen> I think it'S because only ItemChanges have site links. Or at least, that's how it used to be. > 9:46 PM <duesen> Wiring for 'WikibaseClient.EntityChangeFactory' puts a mapping into EntityChangeFactory, which has Item::ENTITY_TYPE => ItemChange::class, > 9:47 PM <addshore> so the only other thing I see that could go wrong is this diff condition > 9:47 PM <addshore> https://github.com/wikimedia/Wikibase/blob/33c8fb8a6fd09d15cc7a3c47bdc6c60e398ce0e2/repo/includes/ChangeDispatcher.php#L362 > 9:54 PM <addshore> i got it > 9:55 PM <addshore> >>> MediaWiki\MediaWikiServices::getInstance()->getService('WikibaseRepo.Store')->getEntityChangeLookup()->loadByChangeIds([547009])[0] > 9:55 PM <addshore> => Wikibase\Repo\Notifications\RepoItemChange {#5576} > 9:55 PM <addshore> But the condition is `if ( $change instanceof ItemChange ) {` The object being returned by the factory was changed https://github.com/wikimedia/Wikibase/commit/d05a0c7ee31f62dd00de583646c45470891f5204#diff-ee6dbb8537c6e9d555c439b164d9ccc2e4d40aedcff12ec86331e5c5637bf7ebR748 but this condition in dispatching was not changed. TASK DETAIL https://phabricator.wikimedia.org/T280627 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Michael, Addshore Cc: Krinkle, daniel, Jakob_WMDE, Mike_Peel, Aklapper, Jheald, Lucas_Werkmeister_WMDE, Addshore, WMDE-leszek, aaron, tstarling, LibrErli, Lea_Lacroix_WMDE, Ladsgroup, RolandUnger, Urbanecm, Bencemac, Tacsipacsi, Kizule, CCicalese_WMF, Lydia_Pintscher, Invadibot, maantietaja, Muchiri124, Hazizibinmahdi, CBogen, Akuckartz, Iflorez, WDoranWMF, alaa_wmde, holger.knust, EvanProdromou, Nandana, Lahi, Gq86, Ramsey-WMF, GoranSMilovanovic, QZanden, LawExplorer, Poyekhali, _jensen, rosalieper, Agabi10, Taiwania_Justo, Scott_WUaS, Pchelolo, Jonas, Ixocactus, Wong128hk, Wikidata-bugs, aude, El_Grafo, Dinoguy1000, Steinsplitter, Mbch331, Keegan
_______________________________________________ Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org
