ItamarWMDE created this task. ItamarWMDE added projects: Wikidata, Wikibase-Quality-Constraints, wdwb-tech. Restricted Application added a subscriber: Aklapper.
TASK DESCRIPTION In T280650 <https://phabricator.wikimedia.org/T280650>, a bug arose as a result of a typo, which could have been caught by some simple unit testing. However, the `suggestion.js` module in WikibaseQualityConstraints is not currently tested, nor is it easy to test, as it relies on some DOM querying and global state. With some modification to the files, however, we would be able to test (at the very least) the hook handler callback attached to `wikibase.entityselector.search` (See suggestions.js:118-163 <https://github.com/wikimedia/mediawiki-extensions-WikibaseQualityConstraints/blob/4c99e1b14e823cdb9b3d335e57e45d06159714c7/modules/suggestions.js#L118-L163>). An exploration of this has begun in **Requirements:** - WikibaseQualityConstraints extension installed **ACs:** [ ] There are at least two unit tests covering all execution paths of the `wikibase.entityselector.search` hook handler <https://github.com/wikimedia/mediawiki-extensions-WikibaseQualityConstraints/blob/4c99e1b14e823cdb9b3d335e57e45d06159714c7/modules/suggestions.js#L118-L163>. TASK DETAIL https://phabricator.wikimedia.org/T283026 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: ItamarWMDE Cc: Aklapper, ItamarWMDE, Invadibot, maantietaja, Akuckartz, Nandana, Lahi, Gq86, Lucas_Werkmeister_WMDE, GoranSMilovanovic, QZanden, LawExplorer, _jensen, rosalieper, Agabi10, Scott_WUaS, abian, Wikidata-bugs, aude, Addshore, Mbch331
_______________________________________________ Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org
