Michael created this task.
Michael added projects: wdwb-tech, Wikidata, Wikidata-Campsite 
(Wikidata-Campsite-Iteration-∞).

TASK DESCRIPTION
  This class could also benefit from some refactoring as it doesn't seem to be 
well scoped or named. In particular, its name would imply that it is build by 
`EntityUsageTableBuilder` but those classes seem to have only little to do with 
each other.
  
  `EntityUsageTable` already gets an `IDatabase` connection injected but also 
creates an ILBFactory and read-connection itself with:
  
    //TODO: Inject
    $this->loadBalancerFactory = 
MediaWikiServices::getInstance()->getDBLoadBalancerFactory();
    $this->readConnection = 
$this->loadBalancerFactory->getMainLB()->getConnection( DB_REPLICA );
  
  and uses that also for waiting for replication:
  
    // Wait for all database replicas to be updated, but only for the affected 
client wiki. The
    // "domain" argument is documented at ILBFactory::waitForReplication.
    $this->loadBalancerFactory->waitForReplication( [ 'domain' => wfWikiID() ] 
);
  
  (`wfWikiID()` is deprecated)

TASK DETAIL
  https://phabricator.wikimedia.org/T283339

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Michael
Cc: Aklapper, Michael, Invadibot, maantietaja, Akuckartz, Iflorez, alaa_wmde, 
Nandana, Lahi, Gq86, GoranSMilovanovic, QZanden, LawExplorer, _jensen, 
rosalieper, Scott_WUaS, Jonas, Wikidata-bugs, aude, Lydia_Pintscher, Addshore, 
Mbch331
_______________________________________________
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org

Reply via email to