Tonina_Zhelyazkova_WMDE added a comment.
The below is chat history from a conversation with @Addshore > We have the same problem on gerrit CI with jenkins: there is an allow list of contributors that have real CI run, otherwise they just have "checks" like linting run and the solution there is either: > > 1. Trust them, add their email to the whitelist and run the CI > > or > > 2. run "recheck" as a trusted contributor, that will run CI > > both of those can possibly also be done for wikit > Another option with a github only flavour would be.... > > 1. if you like the code, create a new internal branch on the repo for the code > 2. change the base of the PR to that branch anhd merge, > 3. make a new PR from that branch > > this is annoying as the contributor that wrote it can't alter the new PR, but they can submit more PRs to the PR > but then on the inner PR you have CI running fully etc, and the user can still add aditional things etc la la la > for some jobs, like publish netlify, a little dance can be done, like have a pull_request one do the build of the site and run code, and have that trigger some other job that does the actual publish with the secret (but doesnt run any code) > I also saw things like this that would allow you to do that https://github.com/marketplace/actions/wait-for-check > So you start 2 jobs, and have 1 wait for th other to finish. And the reason the waiting would be needed is something like this https://github.community/t/triggering-a-new-workflow-from-another-workflow/16250 because 1 workflow can not trigger another workflow TASK DETAIL https://phabricator.wikimedia.org/T283911 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Tonina_Zhelyazkova_WMDE Cc: Addshore, bete, Jakob_WMDE, Aklapper, Tonina_Zhelyazkova_WMDE, Invadibot, maantietaja, Akuckartz, Nandana, Lahi, Gq86, GoranSMilovanovic, QZanden, LawExplorer, _jensen, rosalieper, Scott_WUaS, Volker_E, Wikidata-bugs, aude, Lydia_Pintscher, Mbch331
_______________________________________________ Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org
