Ladsgroup moved this task from Doing to Peer Review on the Wikidata-Campsite (Wikidata-Campsite-Iteration-∞) board. Ladsgroup added a comment.
How you can test the patch above with shellbox: - Clone shellbox (https://gerrit.wikimedia.org/g/mediawiki/libs/Shellbox/) - Change the url in the config/dev-config.json to `http://localhost:8080/shellbox.php` and secretKey to anything else. - Run `make run`. It will build the docker files and the images and then containers and at the end run them in foreground so you'd see requests coming in. - Set shellbox config in your mw: $wgShellboxUrl = 'http://localhost:8080/shellbox.php'; $wgShellboxSecretKey = 'ANYTHING; and then set `wgWBQualityConstraintsFormatCheckerShellboxRatio` to 1. One rather easy way is to see if it's working is to run FormatterCheck tests and replace mocking with the mw service. You would have to comment out `Prevent real HTTP requests from tests` section in `MediaWikiIntegrationTestCase` class. **Troubleshooting the shellbox** - If tests are failing with "Unknown Content-Type" it means it's erroring out which is responding with Content-Type text/html which mw doesn't recognize. My biggest problem seemed to be configuration around entry point URL. Adding another `array_shift( $components );` in Server::guardedExecute() fixed understanding the entry point. - If the secret key is not the same as the one set in mw, it will also fail the same way, you can remove the check in MultipartAction::processInput() (the `!hash_equals( $multipartReader->getHash(), $authHash )`). **Note** Changing php files gets reflected in shellbox server right away but changing configuration files require a rebuild. TASK DETAIL https://phabricator.wikimedia.org/T176312 WORKBOARD https://phabricator.wikimedia.org/project/board/3539/ EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Ladsgroup Cc: Daniel_Mietchen, Rosalie_WMDE, Silvan_WMDE, Krinkle, EBernhardson, Bawolff, abian, Addshore, Ladsgroup, Milimetric, Nikerabbit, Smalyshev, tstarling, daniel, Joe, Lucas_Werkmeister_WMDE, Aklapper, Invadibot, Lalamarie69, maantietaja, Alter-paule, Hazizibinmahdi, Beast1978, Un1tY, Akuckartz, Hook696, Iflorez, Kent7301, alaa_wmde, joker88john, CucyNoiD, Nandana, Gaboe420, Giuliamocci, Cpaulf30, Lahi, Gq86, Af420, Bsandipan, GoranSMilovanovic, QZanden, merbst, LawExplorer, Lewizho99, Maathavan, _jensen, rosalieper, Agabi10, Scott_WUaS, Jonas, Wikidata-bugs, aude, Lydia_Pintscher, Mbch331
_______________________________________________ Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org
