Michael created this task. Michael added projects: Wikidata, Wikidata-Campsite (Wikidata-Campsite-Iteration-∞).
TASK DESCRIPTION Note that `wfGetDB()` uses `\Wikimedia\Rdbms\LoadBalancer::getMaintenanceConnectionRef` internally. Check if _that_ connection ref is really necessary for this use case. Also note from the documentation of `wfGetDB()`: * Note 3: When replacing calls to this with calls to methods on an injected * LoadBalancer, LoadBalancer::getConnectionRef is more commonly needed than * LoadBalancer::getMaintenanceConnectionRef, which is needed for more advanced * administrative tasks. See the IMaintainableDatabase and IDatabase interfaces * for details. Acceptance Criteria: [ ] `wfGetDB()` is no longer used in `SqlEntityIdPager` [ ] `wfGetDB()` is no longer used in tests for this class TASK DETAIL https://phabricator.wikimedia.org/T286251 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Michael Cc: Aklapper, Michael, Invadibot, maantietaja, Akuckartz, Iflorez, alaa_wmde, Nandana, Lahi, Gq86, GoranSMilovanovic, QZanden, LawExplorer, _jensen, rosalieper, Scott_WUaS, Wikidata-bugs, aude, Lydia_Pintscher, Mbch331
_______________________________________________ Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org