Lucas_Werkmeister_WMDE added a comment.
Alright, I uploaded two separate patch sets: - check for empty array in caller <https://gerrit.wikimedia.org/r/705649> + log warning in class <https://gerrit.wikimedia.org/r/705652> fixes the `getLinks()` usage and warns if the function seems to be misused, without changing the footgunny interface - use null to mark no conditions <https://gerrit.wikimedia.org/r/705668> instead changes the interface to remove the footgun; the special value for “no conditions” is now `null`, so that `[]` can mean “return an empty result set”, without callers having to watch out for it Either of them can be merged, but I don’t think merging both would make sense. TASK DETAIL https://phabricator.wikimedia.org/T276762 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Lucas_Werkmeister_WMDE Cc: Michael, Lucas_Werkmeister_WMDE, LSobanski, Addshore, Marostegui, hoo, Aklapper, jcrespo, Biggs657, Invadibot, Lalamarie69, maantietaja, Juan90264, Alter-paule, Beast1978, Un1tY, Akuckartz, Hook696, darthmon_wmde, Kent7301, joker88john, CucyNoiD, Nandana, Gaboe420, Giuliamocci, Cpaulf30, Lahi, Gq86, Af420, Bsandipan, GoranSMilovanovic, QZanden, LawExplorer, Lewizho99, Maathavan, _jensen, rosalieper, Scott_WUaS, Wikidata-bugs, aude, Lydia_Pintscher, Mbch331
_______________________________________________ Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org
