Addshore added a comment.
So it has been tested against beta and it works. The URL had to be changed for the service as it was pointing to wikidata.org and needed to point to beta for beta. Also everything was checked with the service down and things correctly fallback to the old property suggester code. We will need to change something to get this to test and production, as due to the URL issue right now the service can only work for a single site ie. for beta the response now only returns `https://wikidata.beta.wmflabs.org/prop/direct/P4115` Striping this URL prefix will need another code patch written before get get to test.wikidata.org. (This was also foreseen as a possible optimization before this came up) @Martaannaj & @Michaelcochez also discussed a few other things that might need to be tweaked in order to make I'll be taking a final look at the other "next patch" which is the event logging today, and aiming to get it merged. https://gerrit.wikimedia.org/r/c/mediawiki/extensions/PropertySuggester/+/694496/15 Also regarding the checklist, the whole ` operations/mediawiki-config change to switch beta wikidata to enable the event logging / AB test` can go, as this was already enabled in the first mediawiki-config patch! We will have another sync on Friday TASK DETAIL https://phabricator.wikimedia.org/T285098 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Addshore Cc: Lucas_Werkmeister_WMDE, Martaannaj, Michaelcochez, Michael, Addshore, Aklapper, Invadibot, maantietaja, Akuckartz, Iflorez, alaa_wmde, Nandana, Lahi, Gq86, GoranSMilovanovic, QZanden, LawExplorer, _jensen, rosalieper, Scott_WUaS, Wikidata-bugs, aude, Lydia_Pintscher, Sjoerddebruin, Mbch331
_______________________________________________ Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org
