MattCleinman added a comment.
I'm a bit unclear if the suggestion is that we package a JSON file in with the apps, or that the apps download a JSON file dynamically from a server (so that colors can be changed without a release of the app). Either way, unless we're going to start regularly changing colors, I don't think there is a real advantage to the apps using a JSON version of this. Both iOS <https://github.com/wikimedia/wikipedia-ios/blob/44e97088536872ea08482963bbe7a8dc83229602/WMF%20Framework/Theme.swift> and Android <https://github.com/wikimedia/apps-android-wikipedia/blob/2923c466f991e96f1e0a5119c15d510d08a19e6a/app/src/main/res/values/colors.xml> have color schemes set up in ways more typical for their platforms. Unless the values are going to be frequently changing, I'm not sure it's worth the overhead (both in code and moving further from platform standards) to have a script turn JSON/CSS into colors for the mobile apps. That said, we're supportive of platform standardization for MediaWiki. If there are other reasons why it's important for the mobile apps to adopt this style, we're very open to a discussion. TASK DETAIL https://phabricator.wikimedia.org/T277616 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: MattCleinman Cc: MattCleinman, Dbrant, JMinor, AMuigai, R4356th, SGautam_WMF, cmadeo, schoenbaechler, JTannerWMF, Aklapper, Sarai-WMDE, ItamarWMDE, raja_wmde, Pginer-WMF, AnneT, Michael, Volker_E, Invadibot, UOzurumba, WaheedHafez, Ryansama, maantietaja, Confetti68, Rileych, Akuckartz, hueitan, Nandana, Lahi, Gq86, Sharvaniharan, Jcasariego, GoranSMilovanovic, QZanden, LawExplorer, Iniquity, _jensen, rosalieper, JGirault, Scott_WUaS, SBisson, Wikidata-bugs, saper, aude, Lydia_Pintscher, Mbch331, Jay8g
_______________________________________________ Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org
