lucamauri added a comment.
In T124191#7223479 <https://phabricator.wikimedia.org/T124191#7223479>, @lucamauri wrote: > Quick recap of the open tasks related to this modification as suggested here and in Gerrit (by @Lucas_Werkmeister_WMDE and @Ladsgroup): > [cut] With some unexpected complications, I finally completed the modifications on the code itself and on testing: Jenkins just gave me the `+2` So to summarize: > - Implement the new message with link {icon check} done with the modifications discussed above > - Add database icon image as internal resource {icon check} done using OOUI icon with the informational `i` for the time being > - possibly submit it as new graphics in OOUI {icon check} done in T287329 <https://phabricator.wikimedia.org/T287329>, hopefully this will be accepted and could be integrated in a future update of this extension > - remove CSS class `mw-articleplaceholder-createarticle-buttons` for the now unused "Create an article" button's DIV {icon check} done as planned > - Use `Html::messageBox()` to envelop the messagebar {icon ban} As stated above, I frankly don't see any advantage in implementing this, on the contrary it seems to complicate the code. I haven't read any additional comments in weeks, so I assume is safe to drop this suggestion I would say the work is done now — @Manuel correct me if I am wrong — and I hope the patch can be accepted. TASK DETAIL https://phabricator.wikimedia.org/T124191 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: lucamauri Cc: Esc3300, Michael, Ladsgroup, Lucas_Werkmeister_WMDE, Manuel, lucamauri, Izno, Pginer-WMF, hoo, Jan_Dittrich, Bugreporter, Lydia_Pintscher, Aklapper, Lucie, Biggs657, Invadibot, Lalamarie69, maantietaja, Juan90264, Alter-paule, Beast1978, Un1tY, Akuckartz, Hook696, Iflorez, Kent7301, alaa_wmde, joker88john, CucyNoiD, Nandana, Gaboe420, Giuliamocci, Cpaulf30, Lahi, Gq86, Af420, Bsandipan, GoranSMilovanovic, QZanden, cmadeo, LawExplorer, Lewizho99, Maathavan, _jensen, rosalieper, Scott_WUaS, Wikidata-bugs, aude, jayvdb, Ricordisamoa, Mbch331
_______________________________________________ Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org
