Dominicbm added a comment.
In T230315#7303039 <https://phabricator.wikimedia.org/T230315#7303039>, @mwilliams wrote: > Thanks for the great feedback. @Dominicbm you are correct that this needs to be a collection of grouped claims and that my mockups didn't communicate that functionality. > F34618178: reference.jpg <https://phabricator.wikimedia.org/F34618178> Here is a quick mockup of how that might work, keeping each grouped claim in some sort of gray/shaded box. I'd love to keep the functionality as close as possible to Wikidata, while still mapping to the visual design choices that have already been made with SDoC. > > Most of the design decisions that shifted away from exactly replicating Wikidata pre-date my involvement on this work, I'll try and track down some context around that. I'm sure we could revisit those decisions if needed but wouldn't want to conflate that work with this new feature. I think this looks almost perfect. I would not use "Add reference" both inside inside and outside the reference gray box. In my understanding, the entire grouping in one box is a single reference. Wikidata just says "Add" for the claims within the reference, so it's a little less confusing. >> Also, this is minor, but in Wikidata each claim is displayed with a numerical value showing the number of references (even if it is 0). Will this be done in SDoC as well? > > I haven't quite figured this out but happy to spend more time on it if it feels useful. I'm not 100% sure what people use this for in Wikidata, so it's not a big deal to me, but I do find value in aligning the design (unless there is intention behind a change), so that was the main reason I brought it up. TASK DETAIL https://phabricator.wikimedia.org/T230315 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Dominicbm Cc: Addshore, mwilliams, ChristianFerrer, Susannaanas, Cparle, CBogen, Alicia_Fagerving_WMSE, FRomeo_WMF, Fuzheado, GFontenelle_WMF, John_Cummings, Dominicbm, Husky, Spinster, JeanFred, Multichill, Jarekt, valerio.bozzolan, Aklapper, Bugreporter, toberto, Invadibot, Surya742, maantietaja, Mohammed_Sadat_WMDE, Jimfhahn, Dr.uesenfieber, Nintendofan885, Akuckartz, Nandana, JKSTNK, Seddon, Lahi, Gq86, SandraF_WMF, GoranSMilovanovic, QZanden, LawExplorer, Mu301, _jensen, rosalieper, Bodhisattwa, Scott_WUaS, Izno, Wikidata-bugs, aude, Lydia_Pintscher, Mbch331
_______________________________________________ Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org
