Michael added a comment.
In T288443#7324267 <https://phabricator.wikimedia.org/T288443#7324267>, @dang wrote: > In T288443#7324184 <https://phabricator.wikimedia.org/T288443#7324184>, @zeljkofilipin wrote: > >> In T288443#7321615 <https://phabricator.wikimedia.org/T288443#7321615>, @dang wrote: >> >>> @Michael what do you mean by "Tainted references"? >> >> A commit I created recently (714772 <https://gerrit.wikimedia.org/r/c/mediawiki/extensions/Wikibase/+/714772>) removed webdriverio from `view/lib/wikibase-tainted-ref/package.json`. I'm not sure if that's it. > > I just took a look at the `wikibase-tainted-ref` and see no `wdio-wikibase` too :)))))) So it means `wdio-wikibase` is no longer needed in `wikibase-tainted-ref`, right? Sorry, somehow I missed @dang's initial ping. After asking around internally, it turned out that the tainted references browser tests are located at repo/tests/selenium/specs/tainted-ref.js <https://github.com/wikimedia/Wikibase/blob/master/repo/tests/selenium/specs/tainted-ref.js>, and so are probably using the dependencies defined in Wikibase's root package.json. That would mean that removing those dependencies from `view/lib/wikibase-tainted-ref/package.json` was indeed the right thing to do and no updating is needed there anymore. Thank you both for looking into it 🙏 TASK DETAIL https://phabricator.wikimedia.org/T288443 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: dang, Michael Cc: zeljkofilipin, Aklapper, Michael, Suran38, Biggs657, Invadibot, Lalamarie69, maantietaja, Juan90264, Alter-paule, Beast1978, Un1tY, Akuckartz, Hook696, Iflorez, Kent7301, alaa_wmde, joker88john, CucyNoiD, Nandana, Gaboe420, Giuliamocci, Cpaulf30, Lahi, Gq86, Af420, Bsandipan, GoranSMilovanovic, QZanden, LawExplorer, Lewizho99, Maathavan, _jensen, rosalieper, Scott_WUaS, Wikidata-bugs, aude, Lydia_Pintscher, Addshore, Mbch331
_______________________________________________ Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org
