EBernhardson added a comment.
Hmm, yes that makes sense that we want to continue building a working, if slightly misleading, site for current external users. The imagery should be replaced at some point, but we don't have to do it now. If we don't remove the assets from gui in the 4th step the rewrites wont take effect, in the current patches the rewrite only happens when there is no source file in the main build. The simplest option i can think of is to .gitignore the assets in the gui-deploy repo. Then the build can put those files in place and the `git add -A` used by CI wont attempt to add those files to the deploy repo. In that case we drop step 4 above, adjust step 2 to remove the top-level imagery, and then move step 2 after step 3 so the apache config is in place when the assets move. I've updated the depends-on markers in the patches so they have the right sequence. If you can deploy this that would be great, i think everything should be ready now. The remaining patches to transition wdqs gui to the new structure: 1. puppet patch <https://gerrit.wikimedia.org/r/c/operations/puppet/+/714624> to configure apache to read sites/wdqs 2. gui-deploy patch <https://gerrit.wikimedia.org/r/c/wikidata/query/gui-deploy/+/714623> to populate sites/wdqs/ and de-populate imagery from root. At this point site-specific imagery is loading from the per-site dirs. Verify. 3. gui-deploy patch <https://gerrit.wikimedia.org/r/c/wikidata/query/gui-deploy/+/717638> to remove old custom-config.json. TASK DETAIL https://phabricator.wikimedia.org/T280247 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: EBernhardson Cc: Manuel, Ladsgroup, Addshore, Aklapper, Gehel, CBogen, ttaylor, Zbyszko, Suran38, Biggs657, Invadibot, Lalamarie69, MPhamWMF, maantietaja, Juan90264, Alter-paule, Beast1978, Un1tY, Akuckartz, Hook696, Kent7301, joker88john, CucyNoiD, Nandana, Namenlos314, Gaboe420, Giuliamocci, Cpaulf30, Lahi, Gq86, Af420, Bsandipan, Lucas_Werkmeister_WMDE, GoranSMilovanovic, QZanden, EBjune, merbst, LawExplorer, Lewizho99, Maathavan, _jensen, rosalieper, Scott_WUaS, Jonas, Xmlizer, jkroll, Wikidata-bugs, Jdouglas, aude, Tobias1984, Manybubbles, Mbch331
_______________________________________________ Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org
