aude added a comment.

I don't completely understand what is broken and what the expected behavior is 
for various situations.

I tried the wmf/1.25wmf19 branch that we had deployed previously, and tried the 
current version and master (with the fix for suggestions on empty items). I 
have populated my dev wiki with items about US presidents, with standard set of 
statements, references and qualifiers.  I really don't see a difference in 
behavior of the suggester among the different versions.

What seems to work now for references and qualifiers is:

1. for a given main snak property + value combination, it considers all other 
existing statements with that combination and reference + qualifier property 
suggestions are based on that set.

2. if there is no existing main snak property + value combination to match the 
statement one is entering, then then the property suggester doesn't "kick in" 
and offer any enhanced suggestions.  Instead, one gets the default search 
suggestions in not so relevant order.


TASK DETAIL
  https://phabricator.wikimedia.org/T93878

REPLY HANDLER ACTIONS
  Reply to comment or attach files, or !close, !claim, !unsubscribe or !assign 
<username>.

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: aude
Cc: Aklapper, aude, Wikidata-bugs



_______________________________________________
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

Reply via email to