Lydia_Pintscher added a comment.
In T289473#7383839 <https://phabricator.wikimedia.org/T289473#7383839>, @Lucas_Werkmeister_WMDE wrote: > This change cleans up the code so that we don’t check the uniqueness multiple times. However, it has one observable consequence: with that change, the uniqueness of the label of a new property is only validated after the property has already had an ID assigned, so if that check fails, the ID is still consumed. Previously, this doesn’t happen, and if someone tries to create a property with the label of an existing property, no property ID is skipped. Is it acceptable to skip property IDs in this case, or should we leave some duplicate code to perform the check before assigning an ID? If possible we'd avoid skipping IDs unnecessarily. TASK DETAIL https://phabricator.wikimedia.org/T289473 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: toan, Lydia_Pintscher Cc: Lydia_Pintscher, Addshore, Manuel, Lucas_Werkmeister_WMDE, Aklapper, Suran38, Biggs657, Invadibot, Lalamarie69, maantietaja, Juan90264, Alter-paule, Beast1978, Un1tY, Akuckartz, Hook696, Iflorez, Kent7301, alaa_wmde, joker88john, CucyNoiD, Nandana, Gaboe420, Giuliamocci, Cpaulf30, Lahi, Gq86, Af420, Bsandipan, GoranSMilovanovic, QZanden, LawExplorer, Lewizho99, Maathavan, _jensen, rosalieper, Scott_WUaS, Wikidata-bugs, aude, Mbch331
_______________________________________________ Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org
