Lucas_Werkmeister_WMDE added a comment.
> See https://gerrit.wikimedia.org/g/operations/puppet/+/79971d5304a5643b56547ffb956296103fa800c1/modules/profile/templates/wmcs/db/wikireplicas/maintain-views.yaml#839 If I understand correctly, this controls the `wikidatawiki_p.wb_changes` view in the Toolforge / Cloud VPS replicas (e.g. in Quarry). We don’t want to make `wb_changes` rows for deleted revisions public, so we join the `revision` and `archive` tables, and only make the `change_user_id` and `change_info` available if the corresponding revision wasn’t deleted in either of those tables. (We leave the entity ID public in that case, presumably because that’s also more or less public on Special:Log <https://www.wikidata.org/wiki/Special:Log?type=delete&subtype=revision>.) I’m not sure if this requires an index on `change_revision_id` in the `wikidatawiki.wb_changes` table in those replicas (the source of the `wikidata_p.wb_changes` view) – I feel like the most important thing would be that the `revision` and `archive` tables have an index for the join, whereas on `wb_changes` it might not be needed? But in any case, I’m pretty sure that we don’t need this index in production, because those views don’t directly operate on the production tables anyways. TASK DETAIL https://phabricator.wikimedia.org/T292548 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Lucas_Werkmeister_WMDE Cc: Lucas_Werkmeister_WMDE, Aklapper, Michael, karapayneWMDE, Invadibot, maantietaja, Akuckartz, Nandana, Lahi, Gq86, GoranSMilovanovic, QZanden, LawExplorer, _jensen, rosalieper, Scott_WUaS, Wikidata-bugs, aude, Lydia_Pintscher, Addshore, Mbch331
_______________________________________________ Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org
