Silvan_WMDE added subscribers: ItamarWMDE, Silvan_WMDE. Silvan_WMDE added a comment.
**Notes from task breakdown** Copy-Paste: (Ticket to be created by @ItamarWMDE) - use or branch out from https://github.com/wmde/wikit/pull/500 - code is copied and adapted to use fixed tokens - unit tests are copied and adapted to pass Storybook: (Ticket to be created by @ItamarWMDE) - Structure: the Dialog component has its own section is Storybook, called "Dialog". The section contains a "Complex" section displaying the "Complex" dialog. - Documentation: each prop and event are documented and controllable in storybook. - Behavior: users should be able to interact with the dialog. A button with the text "Open dialog" should allow users to trigger the display of the Dialog in case they closed it. (The component should be displayed by default) - Controls: users should be able to modify the copy of the title, the body and the button labels of the dialog. A secondary button/action //might// be optional. - Copy: see Figma <https://www.figma.com/file/gi3JYwSUQYhKS0mHwK25cQwi/WiKit-Design-System?node-id=10349%3A13224> (to be editable by the user) Testing: (Ticket to be created by @Silvan_WMDE) - Add suggested browser tests to wikit in order to test dialog behavior Release: (Ticket to be created by @Silvan_WMDE) - Update Changelog: "New Complex Dialog Component" (in Added section) - A new WiKit pre-release is published with the Dialog component - The Dialog Component is replaced by the WiKit Dialog in Mismatch Finder TASK DETAIL https://phabricator.wikimedia.org/T294849 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Silvan_WMDE Cc: Silvan_WMDE, ItamarWMDE, Lydia_Pintscher, Mattia_Capozzi_WMDE, Aklapper, Sarai-WMDE, karapayneWMDE, Invadibot, maantietaja, Akuckartz, Nandana, Lahi, Gq86, GoranSMilovanovic, QZanden, LawExplorer, _jensen, rosalieper, Scott_WUaS, Volker_E, Wikidata-bugs, aude, Mbch331
_______________________________________________ Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org
