Lucas_Werkmeister_WMDE added a comment.
The 404 is because the file was renamed in the change to upgrade Vue to the migration build of Vue 3 <https://gerrit.wikimedia.org/r/c/mediawiki/core/+/666434>. However, fixing that isn’t enough: diff --git a/package.json b/package.json index ddb8e4ef..8d07b0be 100644 --- a/package.json +++ b/package.json @@ -2,7 +2,7 @@ "private": true, "config": { "remoteVersion": { - "vue": "https://raw.githubusercontent.com/wikimedia/mediawiki/#{ZUUL_BRANCH}/resources/lib/vue/vue.common.prod.js";, + "vue": "https://raw.githubusercontent.com/wikimedia/mediawiki/#{ZUUL_BRANCH}/resources/lib/vue/vue.global.prod.js";, "vuex": "https://raw.githubusercontent.com/wikimedia/mediawiki/#{ZUUL_BRANCH}/resources/lib/vuex/vuex.js"; } }, @@ -40,7 +40,7 @@ "unexpected": "^10.32.1", "unexpected-dom": "^5.0.1", "unexpected-sinon": "^11.0.1", - "vue": "^2.6.11", + "vue": "^2.6.11 || ^3.2.23", "vuex": "^3.1.3", "wdio-mediawiki": "^1.1.1", "wdio-wikibase": "^5.2.0", $ npm run test:mwlibs > test:mwlibs > ZUUL_BRANCH=${ZUUL_BRANCH:-master} lib-version-check vue does not have a version key to check against. When we `require-from-url` the fixed file path, it doesn’t actually return anything: $ node Welcome to Node.js v16.11.0. Type ".help" for more information. > const requireFromUrl = require( 'require-from-url/sync' ); undefined > let remoteLib = requireFromUrl( 'https://raw.githubusercontent.com/wikimedia/mediawiki/master/resources/lib/vue/vue.global.prod.js' ); undefined > remoteLib {} TASK DETAIL https://phabricator.wikimedia.org/T297381 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Lucas_Werkmeister_WMDE Cc: Lucas_Werkmeister_WMDE, Invadibot, maantietaja, Akuckartz, DannyS712, Nandana, Lahi, Gq86, GoranSMilovanovic, Mahir256, QZanden, LawExplorer, _jensen, rosalieper, Bodhisattwa, Scott_WUaS, Wikidata-bugs, aude, Jdforrester-WMF, Mbch331
_______________________________________________ Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org
