Jakob_WMDE added a comment.
From task breakdown: Subtask 1: Return 304 if the given etag is equal to the item revision id - parse header as an integer, compare to latest rev id - respond per spec with last modified and etag headers Subtask 2: Return 304 if given a date with `If-Modified-Since` is equal to or later than the time of the revision creation - ignore `If-Modified-Since` if also given `If-None-Match` - respond per spec with last modified and etag headers Questions to clarify by PM: - We're worried that people might send us lists. Should we really ignore lists (for now)? - Should we somehow prepare for accepting etags with the "weak comparison" indicator? Attempt to parse it as an int? Treat it like nonsense input? Note for PM: > A recipient MUST ignore the If-Modified-Since header field if the received field-value is not a valid HTTP-date, or if the request method is neither GET nor HEAD. from https://httpwg.org/specs/rfc7232.html#header.if-none-match TASK DETAIL https://phabricator.wikimedia.org/T302060 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Jakob_WMDE Cc: Jakob_WMDE, Aklapper, WMDE-leszek, Astuthiodit_1, karapayneWMDE, Invadibot, maantietaja, ItamarWMDE, Akuckartz, Nandana, Lahi, Gq86, GoranSMilovanovic, QZanden, LawExplorer, _jensen, rosalieper, Scott_WUaS, Wikidata-bugs, aude, Lydia_Pintscher, Mbch331
_______________________________________________ Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org
