Lucas_Werkmeister_WMDE added a comment.

  > If the `P218` statement includes more than one value, the application will 
use the first best ranked value (@Lydia_Pintscher does that chime correctly?).
  
  The current implementation almost uses the first best-rank statement, except 
that it falls back to deprecated-rank statements if there are no preferred- or 
normal-rank ones, whereas our usual “best rank” logic never uses 
deprecated-rank statements even if they’re the only ones that exist. The code 
was introduced in April 2017 
<https://gerrit.wikimedia.org/r/c/mediawiki/extensions/WikibaseLexeme/+/344942> 
without any product involvement being recorded as far as I can see (no attached 
Phabricator task, only technical comments), so it’s not clear if the inclusion 
of deprecated statements is intentional or not.
  
  (Also, I think the current implementation will crash if the first best-rank 
statement is a //somevalue// or //novalue// one.)

TASK DETAIL
  https://phabricator.wikimedia.org/T298142

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Lucas_Werkmeister_WMDE
Cc: Lucas_Werkmeister_WMDE, Michael, noarave, ItamarWMDE, guergana.tzatchkova, 
Erdinc_Ciftci_WMDE, Bugreporter, Mahir256, Nikki, Aklapper, Lydia_Pintscher, 
Astuthiodit_1, karapayneWMDE, Invadibot, maantietaja, Akuckartz, Nandana, Lahi, 
Gq86, GoranSMilovanovic, QZanden, LawExplorer, _jensen, rosalieper, 
Bodhisattwa, Scott_WUaS, Wikidata-bugs, aude, Mbch331
_______________________________________________
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org

Reply via email to