guergana.tzatchkova added a comment.
In T290733#7951002 <https://phabricator.wikimedia.org/T290733#7951002>, @guergana.tzatchkova wrote: > Question: What should the text be in this part of the description of the project. > >> aria-label to the menu component. > > I was tempted to hardcode the word "Menu" (aria-label="Menu") and the label but what about the translations to other languages? > > Note: i have chosen the `role="menu"` because it is more appropriate for this component. I have adjusted the rest of the aria attributes to match the menu. (`role="menuitem"` instead of `role="option" as suggested in the ticket.`) I have also appended the description to the aria-label of the menuitem. TASK DETAIL https://phabricator.wikimedia.org/T290733 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: guergana.tzatchkova Cc: ItamarWMDE, Sarai-WMDE, Lydia_Pintscher, Aklapper, Michael, Astuthiodit_1, STHart, karapayneWMDE, bwang, Invadibot, Mooeena, maantietaja, Akuckartz, Nandana, Lahi, Gq86, GoranSMilovanovic, Mahir256, QZanden, Orienteerix, LawExplorer, Flycatchr, Zppix, _jensen, rosalieper, Bodhisattwa, Scott_WUaS, Volker_E, Wikidata-bugs, aude, Dinoguy1000, Mbch331, Jay8g
_______________________________________________ Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org
