Lucas_Werkmeister_WMDE moved this task from Peer Review to Parents / Waiting on 
the Special:NewLexeme revival (Special:NewLexeme revival - sprint 10) board.
Lucas_Werkmeister_WMDE added a comment.


  It looks like the new profile isn’t fully working yet, at least when used via 
the maintenance script – I get the same results for “Engl” with or without the 
maintenance script:
  
    lucaswerkmeister-wmde@mwdebug1001:~$ mwscript 
extensions/Wikibase/repo/maintenance/searchEntities.php wikidatawiki 
--entity-type item --language en --profile-context language_selector_prefix 
<<<Engl 2> /dev/null | jq '.rows | .[] | .snippets | { term, type, text }'
    {
      "term": "Engl",
      "type": "label",
      "text": "family name"
    }
    {
      "term": "ENGL",
      "type": "alias",
      "text": "protein-coding gene in the species Homo sapiens"
    }
    {
      "term": "English",
      "type": "label",
      "text": "West Germanic language"
    }
    {
      "term": "England",
      "type": "label",
      "text": "country in north-west Europe, part of the United Kingdom"
    }
    {
      "term": "English Wikipedia",
      "type": "label",
      "text": "English-language edition of Wikipedia"
    }
    lucaswerkmeister-wmde@mwdebug1001:~$ mwscript 
extensions/Wikibase/repo/maintenance/searchEntities.php wikidatawiki 
--entity-type item --language en <<<Engl 2> /dev/null | jq '.rows | .[] | 
.snippets | { term, type, text }'
    {
      "term": "Engl",
      "type": "label",
      "text": "family name"
    }
    {
      "term": "ENGL",
      "type": "alias",
      "text": "protein-coding gene in the species Homo sapiens"
    }
    {
      "term": "English",
      "type": "label",
      "text": "West Germanic language"
    }
    {
      "term": "England",
      "type": "label",
      "text": "country in north-west Europe, part of the United Kingdom"
    }
    {
      "term": "English Wikipedia",
      "type": "label",
      "text": "English-language edition of Wikipedia"
    }
  
  Same for “Deu”:
  
    lucaswerkmeister-wmde@mwdebug1001:~$ mwscript 
extensions/Wikibase/repo/maintenance/searchEntities.php wikidatawiki 
--entity-type item --language en --profile-context language_selector_prefix 
<<<Deu 2> /dev/null | jq '.rows | .[] | .snippets | { term, type, text }'
    {
      "term": "Deutsche Eislauf-Union",
      "type": "label",
      "text": "voluntary association"
    }
    {
      "term": "Deutschland",
      "type": "alias",
      "text": "country in Central Europe"
    }
    {
      "term": "Deutsch",
      "type": "alias",
      "text": "West Germanic language spoken mainly in Central Europe"
    }
    {
      "term": "Deutsche Demokratische Republik",
      "type": "alias",
      "text": "1949–1990 country in central Europe, unified into modern Germany"
    }
    {
      "term": "Deutsches Kaiserreich",
      "type": "alias",
      "text": "empire in Central Europe between 1871 and 1918"
    }
    lucaswerkmeister-wmde@mwdebug1001:~$ mwscript 
extensions/Wikibase/repo/maintenance/searchEntities.php wikidatawiki 
--entity-type item --language en <<<Deu 2> /dev/null | jq '.rows | .[] | 
.snippets | { term, type, text }'
    {
      "term": "Deutsche Eislauf-Union",
      "type": "label",
      "text": "voluntary association"
    }
    {
      "term": "Deutschland",
      "type": "alias",
      "text": "country in Central Europe"
    }
    {
      "term": "Deutsch",
      "type": "alias",
      "text": "West Germanic language spoken mainly in Central Europe"
    }
    {
      "term": "Deutsche Demokratische Republik",
      "type": "alias",
      "text": "1949–1990 country in central Europe, unified into modern Germany"
    }
    {
      "term": "Deutsches Kaiserreich",
      "type": "alias",
      "text": "empire in Central Europe between 1871 and 1918"
    }
  
  Or “Frenc”:
  
    lucaswerkmeister-wmde@mwdebug1001:~$ mwscript 
extensions/Wikibase/repo/maintenance/searchEntities.php wikidatawiki 
--entity-type item --language en --profile-context language_selector_prefix 
<<<Frenc 2> /dev/null | jq '.rows | .[] | .snippets | { term, type, text }'
    {
      "term": "French Republic",
      "type": "alias",
      "text": "country in Western Europe"
    }
    {
      "term": "French",
      "type": "label",
      "text": "Romance language"
    }
    {
      "term": "French Wikipedia",
      "type": "label",
      "text": "French-language edition of Wikipedia"
    }
    {
      "term": "French Revolution",
      "type": "label",
      "text": "1789 to 1799 social and political revolution in France"
    }
    {
      "term": "French Guiana",
      "type": "label",
      "text": "Overseas department of France in South America"
    }
    lucaswerkmeister-wmde@mwdebug1001:~$ mwscript 
extensions/Wikibase/repo/maintenance/searchEntities.php wikidatawiki 
--entity-type item --language en <<<Frenc 2> /dev/null | jq '.rows | .[] | 
.snippets | { term, type, text }'
    {
      "term": "French Republic",
      "type": "alias",
      "text": "country in Western Europe"
    }
    {
      "term": "French",
      "type": "label",
      "text": "Romance language"
    }
    {
      "term": "French Wikipedia",
      "type": "label",
      "text": "French-language edition of Wikipedia"
    }
    {
      "term": "French Revolution",
      "type": "label",
      "text": "1789 to 1799 social and political revolution in France"
    }
    {
      "term": "French Guiana",
      "type": "label",
      "text": "Overseas department of France in South America"
    }
  
  It looks like this isn’t a bug in the maintenance script, the profile context 
is at least making it to CirrusSearch – if I put in a wrong value, I get an 
error:
  
  counterexample
    lucaswerkmeister-wmde@mwdebug1001:~$ mwscript 
extensions/Wikibase/repo/maintenance/searchEntities.php wikidatawiki 
--entity-type item --language en --profile-context unknown_profile_context 
<<<Engl
    Please input search terms...
    CirrusSearch\Profile\SearchProfileException from line 273 of 
/srv/mediawiki/php-1.39.0-wmf.17/extensions/CirrusSearch/includes/Profile/SearchProfileService.php:
 No default profile found for wikibase_prefix_querybuilder in context 
unknown_profile_context
    #0 
/srv/mediawiki/php-1.39.0-wmf.17/extensions/CirrusSearch/includes/Profile/SearchProfileService.php(258):
 
CirrusSearch\Profile\SearchProfileService->getProfileName('wikibase_prefix...', 
'unknown_profile...', Array)
    #1 
/srv/mediawiki/php-1.39.0-wmf.17/extensions/WikibaseCirrusSearch/src/EntitySearchElastic.php(158):
 CirrusSearch\Profile\SearchProfileService->loadProfile('wikibase_prefix...', 
'unknown_profile...', NULL, Array)
    #2 
/srv/mediawiki/php-1.39.0-wmf.17/extensions/WikibaseCirrusSearch/src/EntitySearchElastic.php(206):
 
Wikibase\Search\Elastic\EntitySearchElastic->loadProfile(Object(CirrusSearch\Search\SearchContext),
 'en')
    #3 
/srv/mediawiki/php-1.39.0-wmf.17/extensions/WikibaseCirrusSearch/src/EntitySearchElastic.php(301):
 Wikibase\Search\Elastic\EntitySearchElastic->getElasticSearchQuery('Engl', 
'en', 'item', false, Object(CirrusSearch\Search\SearchContext))
    #4 
/srv/mediawiki/php-1.39.0-wmf.17/extensions/Wikibase/repo/includes/Api/CombinedEntitySearchHelper.php(49):
 Wikibase\Search\Elastic\EntitySearchElastic->getRankedSearchResults('Engl', 
'en', 'item', 5, false, 'unknown_profile...')
    #5 
/srv/mediawiki/php-1.39.0-wmf.17/extensions/Wikibase/repo/includes/Api/TypeDispatchingEntitySearchHelper.php(48):
 Wikibase\Repo\Api\CombinedEntitySearchHelper->getRankedSearchResults('Engl', 
'en', 'item', 5, false, 'unknown_profile...')
    #6 
/srv/mediawiki/php-1.39.0-wmf.17/extensions/Wikibase/repo/maintenance/searchEntities.php(106):
 
Wikibase\Repo\Api\TypeDispatchingEntitySearchHelper->getRankedSearchResults('Engl',
 'en', 'item', 5, false, 'unknown_profile...')
    #7 
/srv/mediawiki/php-1.39.0-wmf.17/includes/OrderedStreamingForkController.php(142):
 Wikibase\Repo\Maintenance\SearchEntities->doSearch('Engl')
    #8 
/srv/mediawiki/php-1.39.0-wmf.17/includes/OrderedStreamingForkController.php(69):
 OrderedStreamingForkController->consumeNoFork()
    #9 
/srv/mediawiki/php-1.39.0-wmf.17/extensions/Wikibase/repo/maintenance/searchEntities.php(65):
 OrderedStreamingForkController->start()
    #10 
/srv/mediawiki/php-1.39.0-wmf.17/maintenance/includes/MaintenanceRunner.php(309):
 Wikibase\Repo\Maintenance\SearchEntities->execute()
    #11 /srv/mediawiki/php-1.39.0-wmf.17/maintenance/doMaintenance.php(85): 
MediaWiki\Maintenance\MaintenanceRunner->run()
    #12 
/srv/mediawiki/php-1.39.0-wmf.17/extensions/Wikibase/repo/maintenance/searchEntities.php(160):
 require_once('/srv/mediawiki/...')
    #13 /srv/mediawiki/multiversion/MWScript.php(120): 
require_once('/srv/mediawiki/...')
    #14 {main}

TASK DETAIL
  https://phabricator.wikimedia.org/T307869

WORKBOARD
  https://phabricator.wikimedia.org/project/board/5983/

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Lucas_Werkmeister_WMDE
Cc: ItamarWMDE, dcausse, Lucas_Werkmeister_WMDE, MPhamWMF, Aklapper, 
Lydia_Pintscher, Astuthiodit_1, Nikospappas1312, 786, Biggs657, karapayneWMDE, 
Invadibot, Universal_Omega, maantietaja, Juan90264, Alter-paule, Beast1978, 
CBogen, Un1tY, Akuckartz, Hook696, Kent7301, joker88john, CucyNoiD, Nandana, 
Gaboe420, Giuliamocci, Cpaulf30, Lahi, Gq86, Af420, Bsandipan, 
GoranSMilovanovic, Mahir256, QZanden, EBjune, LawExplorer, Lewizho99, 
Maathavan, _jensen, rosalieper, Bodhisattwa, Neuronton, Scott_WUaS, 
Wikidata-bugs, aude, Gryllida, Mbch331
_______________________________________________
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org

Reply via email to