Sarai-WMDE added a comment.

  Thanks for the change, @guergana.tzatchkova! Looks like the input now display 
the right color in Chrome and Safari. The problem with Firefox is that the 
browser applies an opacity of 0.54 by default, that's what causing the lower 
contrast:
  
  F35399349: Screenshot 2022-08-05 at 12.04.57.png 
<https://phabricator.wikimedia.org/F35399349>
  
  I think we should specify that the placeholder has full opacity at the 
component level, something like:
  
    &::placeholder {
                color: $wikit-Input-placeholder-color;
                    opacity: $wikit-Input-placeholder-opacity; [NEW]
        }
  
  This involves creating a couple of tokens:
  
  The new component token `$wikit-Input-placeholder-color` will consume a new 
alias token called `$opacity-base`, that will need to be added to the 
alias.json file 
<https://github.com/wmde/wikit/blob/master/tokens/properties/alias.json#L380>. 
The latter alias token will consume the global token `$opacity-100`.

TASK DETAIL
  https://phabricator.wikimedia.org/T312633

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: guergana.tzatchkova, Sarai-WMDE
Cc: Volker_E, Lydia_Pintscher, Quiddity, Aklapper, Sarai-WMDE, Astuthiodit_1, 
STH, karapayneWMDE, Invadibot, maantietaja, ItamarWMDE, Akuckartz, Nandana, 
Lahi, Gq86, GoranSMilovanovic, QZanden, LawExplorer, _jensen, rosalieper, 
Scott_WUaS, Wikidata-bugs, aude, Mbch331
_______________________________________________
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org

Reply via email to