guergana.tzatchkova added a comment.
@Sarai-WMDE @noarave I am reviewing this task and the measures both before and after applying the patch are different in Chrome and Firefox. I am assuming you made both the original test and the fix using Chrome? Do we want to have different numbers in different browsers? I know this is due to the relative units, but is the base different for both browsers? Examples: (in the branch submitted by Noa, tho these differences exist also in the current version of master) `margin-bottom` of text "You can check..." - Firefox: 18px, Chrome: 16px `wbl-snl-copyright` paragraph computed font size - Firefox: 14.625px, Chrome 13px --- I don't understand this requirement: > The last paragraph inside the infopanel shouldn't display a margin-block-end, so the minimum spacing between said paragraph and the infopanel's border is only of 24px (1.5rem). because the distance between the paragraph and the lower border of the gray infopanel doesn't seem to be determined by any of its contents, its height is matching the height of the white infopanel. To summarize: Noa's fix is solving the issues for Chrome, but the inconsistency between measures in both browsers remains. TASK DETAIL https://phabricator.wikimedia.org/T312652 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: noarave, guergana.tzatchkova Cc: guergana.tzatchkova, Lucas_Werkmeister_WMDE, Aklapper, Sarai-WMDE, Hellket777, LisafBia6531, Astuthiodit_1, 786, Biggs657, karapayneWMDE, Invadibot, maantietaja, Juan90264, Alter-paule, Beast1978, ItamarWMDE, Un1tY, Akuckartz, Hook696, Kent7301, joker88john, CucyNoiD, Nandana, Gaboe420, Giuliamocci, Cpaulf30, Lahi, Gq86, Af420, Bsandipan, GoranSMilovanovic, QZanden, LawExplorer, Lewizho99, Maathavan, _jensen, rosalieper, Neuronton, Scott_WUaS, Wikidata-bugs, aude, Mbch331
_______________________________________________ Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org
