Lucas_Werkmeister_WMDE added a comment.
I just realized that we probably don’t want to prohibit duplication of mul labels under all circumstances. Consider an item that has the mul label A and the pt label B. Now suppose that pt-br users should see the label as A. In that case, it should be allowed to set the pt-br label to A, even though that’s the same as the mul label – because it’s not redundant: it overrides the pt label. I think I would implement this as: when editing a non-mul label, get the label in that language for the item, assuming the label doesn’t exist in the language itself; if the resulting term fallback is in mul, then only allow the edit if the label is different from the mul fallback; but if the term fallback is in any other language, then don’t compare anything with the mul label. (Maybe we’ll need to optimize this code, e.g. by first checking if a mul label exists at all, before computing term fallbacks for all the languages affected by the edit.) TASK DETAIL https://phabricator.wikimedia.org/T306918 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Lucas_Werkmeister_WMDE Cc: mrephabricator, Lucas_Werkmeister_WMDE, Lydia_Pintscher, Nikki, Mahir256, Manuel, Aklapper, Astuthiodit_1, karapayneWMDE, Invadibot, maantietaja, ItamarWMDE, Akuckartz, Nandana, Lahi, Gq86, GoranSMilovanovic, QZanden, LawExplorer, _jensen, rosalieper, Scott_WUaS, Wikidata-bugs, aude, Mbch331
_______________________________________________ Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org
