Lucas_Werkmeister_WMDE added a comment.
In T317682#8329113 <https://phabricator.wikimedia.org/T317682#8329113>, @Lucas_Werkmeister_WMDE wrote: > If I’m not mistaken, the “old search” side of this tracking happens in this code <https://gerrit.wikimedia.org/g/mediawiki/extensions/WikimediaEvents/+/3a4b406e0bfbb2d77288f785cc21e1b4a5360d7b/modules/ext.wikimediaEvents/searchSatisfaction.js#602> – that looks like we could change it to log either “click” or “submit” depending on the `data.action`, without actually changing the behavior (to reduce the amount of required changes). Does that sound okay? I think I got this the wrong way around – the `searchSatisfaction.js` code I linked already logs both `submit-form` and `click-result` actions as a `click`; there’s nothing to be changed from a submit to a click here. If I understand @phuedx in T317682#8254889 <https://phabricator.wikimedia.org/T317682#8254889> correctly, the part that needs to change is the code that //emits// `mediawiki.searchSuggest` tracking, whereas `searchSatisfaction.js` is a //consumer// of this tracking. The emitting side is in MediaWiki core (and only there, if I’m not mistaken). TASK DETAIL https://phabricator.wikimedia.org/T317682 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Lucas_Werkmeister_WMDE Cc: mpopov, cchen, EBernhardson, ItamarWMDE, dcausse, Gehel, Jdlrobson, Catrope, AnneT, jhsoby, Aklapper, Michael, Lucas_Werkmeister_WMDE, phuedx, Adamm71, hnijhuis, Jersione, Hellket777, NHillard-WMF, LisafBia6531, Astuthiodit_1, STH, 786, Biggs657, Patafisik_WMF, karapayneWMDE, Invadibot, MPhamWMF, Selby, Universal_Omega, maantietaja, Juan90264, Alter-paule, NavinRizwi, Beast1978, CBogen, Un1tY, Akuckartz, Demian, Hook696, Kent7301, joker88john, DannyS712, CucyNoiD, Nandana, Gaboe420, Amorymeltzer, Giuliamocci, Cpaulf30, Lahi, Gq86, Af420, Bsandipan, Xover, GoranSMilovanovic, QZanden, EBjune, LawExplorer, Lewizho99, JJMC89, Maathavan, Iniquity, _jensen, rosalieper, Agabi10, Neuronton, Scott_WUaS, Volker_E, Wikidata-bugs, aude, Dinoguy1000, Mbch331, Jay8g
_______________________________________________ Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org
