Jdlrobson added a comment.

  > The module 'wikibase.lexeme.lexemeview' must not have target 'mobile' 
because its dependency 'jquery.ui.languagesuggester' does not have it
  
  
  
  - jquery.ui.languagesuggester targets neither desktop or mobile so defaults 
to "desktop" (as its not an ES6 module)
  - With T323542 <https://phabricator.wikimedia.org/T323542>, 
wikibase.lexeme.lexemeview as an ES6 module would now target desktop AND mobile
  - Since  wikibase.lexeme.lexemeview depends on jquery.ui.languagesuggester 
there is  now a mismatch on mobile.
  
  I've been relying on CI heavily for these changes,  I'm not sure why this 
wasn't triggered when the core patch merged so I'll need to investigate this 
further.  Presumably WikibaseLexeme is not including in the core CI build since 
https://gerrit.wikimedia.org/r/c/mediawiki/core/+/864923 is passing validation 
without https://gerrit.wikimedia.org/r/865101 ?

TASK DETAIL
  https://phabricator.wikimedia.org/T324525

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Jdlrobson
Cc: Michael, Physikerwelt, Jdlrobson, Krinkle, kostajh, EBernhardson, Adamm71, 
Jersione, Hellket777, LisafBia6531, Astuthiodit_1, 786, Biggs657, 
karapayneWMDE, Invadibot, maantietaja, Juan90264, Alter-paule, Beast1978, 
ItamarWMDE, Un1tY, Akuckartz, Hook696, Kent7301, joker88john, CucyNoiD, 
Nandana, Gaboe420, Giuliamocci, Cpaulf30, Lahi, Gq86, Af420, Bsandipan, 
GoranSMilovanovic, Mahir256, QZanden, LawExplorer, Vali.matei, Lewizho99, 
Maathavan, _jensen, rosalieper, xSavitar, Neuronton, Scott_WUaS, Nirmos, 
Wikidata-bugs, aude, Dinoguy1000, Jdforrester-WMF, Mbch331
_______________________________________________
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org

Reply via email to