Push-f created this task. Push-f added projects: Wikidata, Wikibase-DataModel-Serialization, Wikibase-DataModel. Restricted Application added a subscriber: Aklapper. Restricted Application added a project: wdwb-tech.
TASK DESCRIPTION I wanted to work on a PR to address T323618 <https://phabricator.wikimedia.org/T323618> so I tried: git clone https://github.com/wmde/WikibaseDataModelSerialization composer install composer test Only to discover that the tests fail with a bunch of `Error: Class 'Wikibase\DataModel\Entity\NumericPropertyId' not found` errors. I did some digging and this is apparently because #Wikibase-DataModel-Serialization <https://phabricator.wikimedia.org/tag/wikibase-datamodel-serialization/> depends on #wikibase-datamodel <https://phabricator.wikimedia.org/tag/wikibase-datamodel/>, where the `NumericPropertyId` class has been introduced in T289125 <https://phabricator.wikimedia.org/T289125>. However #wikibase-datamodel <https://phabricator.wikimedia.org/tag/wikibase-datamodel/> has not had a release since and #Wikibase-DataModel-Serialization <https://phabricator.wikimedia.org/tag/wikibase-datamodel-serialization/> has been changed to use the new class in a14086394e8cd813a29ddcae6c9338dc9665a1f3 <https://github.com/wmde/WikibaseDataModelSerialization/commit/a14086394e8cd813a29ddcae6c9338dc9665a1f3> without updating the `wikibase/data-model` dependency in `composer.json`. So I think a new version of #wikibase-datamodel <https://phabricator.wikimedia.org/tag/wikibase-datamodel/> should be released and the `composer.json` of #Wikibase-DataModel-Serialization <https://phabricator.wikimedia.org/tag/wikibase-datamodel-serialization/> should be updated accordingly. I was initially really confused why the README proudly declared "build passing" but apparently the Travis CI is dead <https://travis-ci.org/github/wmde/WikibaseDataModelSerialization>, having last run 2 years ago. TASK DETAIL https://phabricator.wikimedia.org/T325422 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Push-f Cc: Push-f, Aklapper, Astuthiodit_1, karapayneWMDE, Invadibot, maantietaja, ItamarWMDE, Akuckartz, Nandana, Lahi, Gq86, GoranSMilovanovic, QZanden, LawExplorer, _jensen, rosalieper, Scott_WUaS, Wikidata-bugs, aude, Mbch331
_______________________________________________ Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org
