alexhollender_WMF added a subscriber: KieranMcCann. alexhollender_WMF added a comment.
In T328069#8631022 <https://phabricator.wikimedia.org/T328069#8631022>, @Nux wrote: > Also not sure why are going with overlines. I think you will be opening another front of controversial changes. Headers are prominently underlined on Wikipedia from like... always. I think changing that is a mistake. Also note that the page is now very inconsistent. > > - page title - underlined > - left actions - underlined > - right actions - underlined > - left sidebar title - underlined > - left sidebar header items - overlined > - right sidebar title - underlined? > - right sidebar header items - overlined > > You have over and underlined headers right next to each other. For me it looks bad (and not only because I'm editing Wikipedia for 17 years). > > F36863116: obraz.png <https://phabricator.wikimedia.org/F36863116> > > But if you are going to force overlined headers please at least make those headers in the menu more distinct and make the font for items smaller. Which will also be beneficial because the page tools will have a smaller height. @Nux thanks so much for pointing this out. There is clearly more work to be done to achieve consistency here (and thank you for noting the established patterns that have existed for quite some time). Since the Main menu and Tools menu have titles, and I put an underline under those titles, I wanted to avoid a sort of double underline situation where the section headings of the menus also had underlines. In any case there's definitely room for improvement. @KieranMcCann, as well as the #design-systems-team <https://phabricator.wikimedia.org/tag/design-systems-team/>, will be working on a variety of improvements to menus, and will be sure to include this in that work. TASK DETAIL https://phabricator.wikimedia.org/T328069 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Edtadros, alexhollender_WMF Cc: KieranMcCann, Pginer-WMF, TheresNoTime, Patriccck, Urbanecm, jhsoby, GMikesell-WMF, Nux, Amire80, Zapipedia-WMF, Patafisik, RolandUnger, Iniquity, Raymond, ovasileva, alexhollender_WMF, Lucas_Werkmeister_WMDE, ItamarWMDE, Jdrewniak, Terasail, Aklapper, Jdlrobson, Themindcoder, Adamm71, JCW555, hnijhuis, Jersione, Hellket777, LisafBia6531, Astuthiodit_1, Nishu02, 786, Biggs657, Patafisik_WMF, karapayneWMDE, Invadibot, Selby, Universal_Omega, maantietaja, Juan90264, Alter-paule, Beast1978, Un1tY, Akuckartz, Demian, Hook696, Kent7301, joker88john, CucyNoiD, Nandana, Gaboe420, lucamauri, Giuliamocci, Cpaulf30, Lahi, Gq86, Af420, Bsandipan, GoranSMilovanovic, QZanden, LawExplorer, Winter, Lewizho99, Maathavan, _jensen, rosalieper, Agabi10, Neuronton, Scott_WUaS, Volker_E, Wikidata-bugs, aude, Mbch331
_______________________________________________ Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org
