Nikki added a comment.
In T214002#8691240 <https://phabricator.wikimedia.org/T214002#8691240>, @Lucas_Werkmeister_WMDE wrote: > So the first of the above changes, Make DateFormatParser accept more Asian/Chinese date formats <https://gerrit.wikimedia.org/r/c/mediawiki/extensions/Wikibase/+/886919>, enables Wikibase to parse dates like “2023年3月12日” in Japanese as 2023-03-12. That change seems unproblematic and is good to go, I think. > > However, the second one, Let DateFormatParser accept and skip redundant day of the week <https://gerrit.wikimedia.org/r/c/mediawiki/extensions/Wikibase/+/886920>, is a bit trickier. With that change, //all// of the following would parse as 2023-03-12 in Japanese: > > 1. 2023年3月12日 – as before > 2. 2023年3月12日 (日) – correct weekday (Sunday) > 3. 2023年3月12日 (一) – blank weekday > 4. 2023年3月12日 (whatever) – nonsense weekday > 5. 2023年3月12日 (月) – **different** weekday (Monday) That sounds reasonable to me. It seems plausible that the bit after the date could sometimes not actually be the weekday (e.g. "the choice we made on 2023-03-12 (Monday) doesn't work so we need to pick a different day") and I would probably be pleased that it extracted the date from the input instead of making me delete all the extra text first. > I think this is a product question (and, IIRC, not one we explicitly discussed in yesterday’s bug triage hour): when users input a date with a named day of the week, and the day of the week doesn’t match the date (as in “2023年3月12日 (月)”), should the date successfully parse (ignoring the named day of the week) or not? > > IMHO, it’s at least conceivable that users would specify the day of the week as an intentional redundancy, and expect the software to check that they didn’t make a mistake in either the numeric date or the day of the week. On the other hand, I don’t think it’s realistic for us to return a specific error like “this date doesn’t match the specified day of the week”; the result would just be a parse error, or worse, Wikibase might even fall back to another parser and still successfully parse the date: just like it’s already able to parse “2001年8月31日”, for instance. I would interpret a parse error in this situation as "we don't support including the day of the week" and delete it from the input, leaving just "2023年3月12日", so I think it would only make sense to check whether the day of the week matches if it also has an error message for that situation. TASK DETAIL https://phabricator.wikimedia.org/T214002 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Nikki Cc: Lucas_Werkmeister_WMDE, Nikki, thiemowmde, Nicolas_Raoul, Aklapper, Themindcoder, Adamm71, Jersione, Hellket777, LisafBia6531, Astuthiodit_1, 786, Biggs657, karapayneWMDE, Invadibot, maantietaja, Juan90264, Alter-paule, Beast1978, ItamarWMDE, Un1tY, Akuckartz, Hook696, Kent7301, joker88john, CucyNoiD, Nandana, Gaboe420, Giuliamocci, Cpaulf30, Lahi, Gq86, Af420, Bsandipan, GoranSMilovanovic, QZanden, LawExplorer, Lewizho99, Maathavan, _jensen, rosalieper, Neuronton, Scott_WUaS, Wikidata-bugs, aude, Mbch331
_______________________________________________ Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org
