Michael added a comment.

  I looked into it briefly to remind myself of what is going on. This was added 
in context of T310259 <https://phabricator.wikimedia.org/T310259>. And looking 
at that script 
https://gerrit.wikimedia.org/r/plugins/gitiles/mediawiki/extensions/Wikibase/+/60a3d9821fe5460930a47a9565b1aa0559cf1fbf/client/resources/wikibase.client.vector-2022.js:
  
  name=wikibase.client.vector-2022.js
        var itemId = mw.config.get( 'wgWikibaseItemId' );
        if ( !itemId || [ null, 'error', 'registered' ].indexOf( 
mw.loader.getState( 'ext.uls.interface' ) ) !== -1 ) {
                return;
        }
    
        // wait for ext.uls.interface to be ready,
        // and lazy-load the other dependencies now that we know they're needed
        mw.loader.using( [
                'mw.config.values.wbRepo',
                'mw.config.values.wbSiteDetails',
                'ext.uls.interface',
                'oojs-ui.styles.icons-editing-core'
        ], function () {
  
  The intention is indeed to lazy-load these dependencies. But we may have 
misunderstood how something in how ResourceLoader works and made a mistake 
there?
  
  Another approach could be to create a config module that contains the client 
config only for the current site and not all sites, that should then be much 
smaller than wbSiteDetails. Though that might be a non-trivial thing to do.
  
  Also, this loads all the icons in `oojs-ui.styles.icons-editing-core`, would 
be nice if we could only load the one icon that we actually need.

TASK DETAIL
  https://phabricator.wikimedia.org/T331760

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Michael
Cc: Lucas_Werkmeister_WMDE, Jdlrobson, Michael, ItamarWMDE, Manuel, Peter, 
Aklapper, nray, JCW555, hnijhuis, Astuthiodit_1, Nishu02, Patafisik_WMF, 
karapayneWMDE, Invadibot, Selby, maantietaja, Akuckartz, Demian, Nandana, Lahi, 
Gq86, GoranSMilovanovic, QZanden, LawExplorer, Winter, Vali.matei, Iniquity, 
_jensen, rosalieper, Agabi10, Scott_WUaS, Volker_E, Wikidata-bugs, aude, 
Lydia_Pintscher, Mbch331
_______________________________________________
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org

Reply via email to