Michael added a comment.
In T333660#8753446 <https://phabricator.wikimedia.org/T333660#8753446>, @Lucas_Werkmeister_WMDE wrote: >> Hence, EntitySchema tests should run as part of the Wikibase test suite in CI, so that we know when a change to Wikibase would break EntitySchema > > To be honest, I’m not sure that this is worth the added slowdown to Wikibase CI that would (I assume) result from adding EntitySchema to it. I don’t think the risk of EntitySchema breaking from Wikibase changes is very large. Mh, to me this partly depends on the features that we are going to add in the future. Would it be possible to run just _some_ of the EntitySchema tests in Wikibase CI? For example, I could see us mainly using api-testing in EntitySchema to assert that the integration works as expected (esp. around dumps, rdf, json and such). Maybe we can limit it to that? As an alternative, I could see us adding EntitySchema to the "runs the tests on the master branch every day" list of repositories, if it is not there already. (If it is, then I'm suprised that I have never heard about a failing browser test? Given how flaky they used to be...) TASK DETAIL https://phabricator.wikimedia.org/T333660 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Michael Cc: Lucas_Werkmeister_WMDE, Aklapper, Michael, Astuthiodit_1, karapayneWMDE, Invadibot, maantietaja, ItamarWMDE, Akuckartz, pdehaye, Nandana, Lahi, Gq86, Andrawaag, GoranSMilovanovic, QZanden, YULdigitalpreservation, LawExplorer, Salgo60, _jensen, rosalieper, Scott_WUaS, MisterSynergy, abian, Wikidata-bugs, aude, Lydia_Pintscher, Mbch331
_______________________________________________ Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org