ItamarWMDE created this task.
ItamarWMDE added projects: wmde-wikidata-tech, Wikidata, Shape Expressions.

TASK DESCRIPTION
  Currently, the registered `onBeforeDisplayNoArticleText` hook handler is 
registered through a static method of the `EntitySchemaHooks` class. However, 
as this class depends on some MediaWiki services, it could leverage from the 
new MediaWiki dependency injection system.
  
  To improve the analyzability and testability of this hook handler, we should 
refactor this static handler to a class that implements the 
`BeforeDisplayNoArticleTextHook` interface and has its dependencies injected 
via constructor.
  
  **Acceptance Criteria**:
  
  [ ] The hook handler function is moved to a class that implements the 
`BeforeDisplayNoArticleTextHook` interface and injects its dependent services
  [ ] The hook handler's registration in `extension.json` declares its service 
dependencies for dependency injection

TASK DETAIL
  https://phabricator.wikimedia.org/T336922

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: ItamarWMDE
Cc: Aklapper, ItamarWMDE, Astuthiodit_1, karapayneWMDE, Invadibot, maantietaja, 
Akuckartz, pdehaye, Nandana, Lahi, Gq86, Andrawaag, GoranSMilovanovic, QZanden, 
YULdigitalpreservation, LawExplorer, Salgo60, _jensen, rosalieper, Scott_WUaS, 
MisterSynergy, abian, Wikidata-bugs, aude, Lydia_Pintscher, Mbch331
_______________________________________________
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org

Reply via email to