Daimona added a comment.
In T340928#8987551 <https://phabricator.wikimedia.org/T340928#8987551>, @Lucas_Werkmeister_WMDE wrote: > In T340928#8984321 <https://phabricator.wikimedia.org/T340928#8984321>, @Daimona wrote: > >> Right, I didn't realize that since Wikibase doesn't have a single extension.json file, LocalSettingsGenerator will use the old style `require_once`, which includes `Wikibase.php`, which provides some overrides for CI. >> >> I'm going to skip the test if the needed setting isn't enabled, and this will fix this task. > > I uploaded an alternative way to improve the test, but I disagree that this fixes the task. It sounds like the issue here is that your changes cause our CI-only settings to not be loaded in CI. That’s a problem even if all the remaining tests are green. Yeah, sorry for the confusion. What I meant is that the patch above will fix the test failure when the setting's not enabled, which is what I was getting on my local. The config fix for switching to composer PHPUnit is r935034 <https://gerrit.wikimedia.org/r/c/mediawiki/extensions/Wikibase/+/935034>, which ensures that the test will be executed after the switch. That's in scope for T90875 <https://phabricator.wikimedia.org/T90875> though, not this task. TASK DETAIL https://phabricator.wikimedia.org/T340928 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Daimona Cc: Lucas_Werkmeister_WMDE, Aklapper, Daimona, Isabelladantes1983, Themindcoder, Adamm71, Jersione, Hellket777, LisafBia6531, Astuthiodit_1, 786, Biggs657, karapayneWMDE, Invadibot, maantietaja, Juan90264, Alter-paule, Beast1978, ItamarWMDE, Un1tY, Akuckartz, Hook696, Kent7301, joker88john, CucyNoiD, Nandana, Gaboe420, lucamauri, Giuliamocci, Cpaulf30, Lahi, Gq86, Af420, Bsandipan, GoranSMilovanovic, QZanden, LawExplorer, Lewizho99, Maathavan, _jensen, rosalieper, Neuronton, Scott_WUaS, Wikidata-bugs, aude, Mbch331
_______________________________________________ Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org
