hoo added a subscriber: thiemowmde.
hoo added a comment.

  I just looked into this and the tracking category should be recorded all the 
time (it's a bug that it's not).
  
  Here's how this happens: `TrackingCategories::resolveTrackingCategory`, which 
is called indirectly via `Parser::addTrackingCategory`, expects to get a 
`$contextPage`. If this passed `$contextPage` is null or a special page it will 
abort (and thus no tracking category will be recorded). In 
`CachingKartographerEmbeddingHandler` we use 
`RequestContext::getMain()->getTitle() ?? Title::makeTitle( NS_SPECIAL, 
'BlankPage' )` to determine the page (which will eventually end up as 
`$contextPage`). As can be seen here, depending on the context of the call, 
this might be the actual page (eg. when purging using 
https://www.wikidata.org/wiki/Q7105617?action=purge) or Special:BlankPage (eg. 
when editing or purging via API).
  
  T337222: Properly inject the page and revision id when rendering Kartographer 
maps <https://phabricator.wikimedia.org/T337222> would solve this.
  
  As a stop gap, we could either manually add the category in Wikibase or 
loosen the checks in `TrackingCategories::resolveTrackingCategory`.
  
  If we decide that we don't want to have that tracking category after all, a 
setting could be added to Kartographer to turn it of for Wikidata (or just for 
entity namespaces).

TASK DETAIL
  https://phabricator.wikimedia.org/T344577

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: hoo
Cc: thiemowmde, hoo, Lydia_Pintscher, Izno, Aklapper, Nikki, 
Danny_Benjafield_WMDE, mrephabricator, Astuthiodit_1, karapayneWMDE, Invadibot, 
maantietaja, ItamarWMDE, Akuckartz, Alilje, Nandana, Lahi, Gq86, Looniverse, 
GoranSMilovanovic, Sturm, QZanden, Orienteerix, LawExplorer, _jensen, 
rosalieper, JGirault, Scott_WUaS, phabyogi, Susannaanas, lxbarth, Planemad, 
Wikidata-bugs, aude, Yurik, TheDJ, Mbch331, Jay8g
_______________________________________________
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org

Reply via email to