Sarai-WMDE created this task. Sarai-WMDE added projects: Wikidata Dev Team, Wikidata, Mismatch Finder. Restricted Application added a subscriber: Aklapper.
TASK DESCRIPTION Problem ------- The layout, typography and custom elements that –together with WiKit components – make up Mismatch Finder's UI were styled (in most cases) using WiKit tokens. The WiKit design system is now on its deprecation path, as it has been superseded by Codex, the now official Wikimedia design system. WiKit tokens will be deprecated together with the legacy system, and thus their use is not advised. Solution -------- We need to import Codex tokens and use them to replace the WiKit tokens (of all global, aliases and component types) that were used to style Mismatch Finder. This will take us a step closer to switching to the new design system and deprecating the old. Here's a list of WiKit tokens and their equivalent Codex styles <https://docs.google.com/spreadsheets/d/1CmrW7JVt9o2TvAfyIVScOE_Vc1h8DLpBqvsVhAB84kU/edit#gid=1602375525>. Considerations -------------- - Layout spacing styles: Unfortunately, `$dimension-layout` tokens do not have an equivalent style in Codex. We'll need to use custom variables to replace these. - The task's goal is to replace WiKit tokens in use in the Mismatch Finder app's Sass files. Nevertheless, we should consider the stretch goal of improving the token coverage by replacing discrete values too, if detected. - Files impacted by the token replacement: AuthWidget.vue <https://github.com/wmde/wikidata-mismatch-finder/blob/development/resources/js/Components/AuthWidget.vue>, LoadingOverlay.vue <https://github.com/wmde/wikidata-mismatch-finder/blob/development/resources/js/Components/LoadingOverlay.vue>, MismatchRow.vue <https://github.com/wmde/wikidata-mismatch-finder/blob/development/resources/js/Components/MismatchRow.vue#L204>, MismatchToolFooter.vue <https://github.com/wmde/wikidata-mismatch-finder/blob/development/resources/js/Components/WikidataToolFooter.vue#L73>, Homer.vue <https://github.com/wmde/wikidata-mismatch-finder/blob/development/resources/js/Pages/Home.vue#L245>, Layout.vue <https://github.com/wmde/wikidata-mismatch-finder/blob/development/resources/js/Pages/Layout.vue#L180>, Layout.vue <https://github.com/wmde/wikidata-mismatch-finder/blob/development/resources/js/Pages/Results.vue#L380>, app.scss <https://github.com/wmde/wikidata-mismatch-finder/blob/development/resources/sass/app.scss> - We'll have to recreate _typography.scss <https://github.com/wmde/wikidata-mismatch-finder/blob/development/resources/sass/_typography.scss> using Codex's less tokens. (Codex typography mixins are not available yet). Acceptance criteria ------------------- [ ] All the WiKit tokens used to style the Mismatch Finder app that have an equivalent in Codex are replaced [ ] WiKit tokens used to style the Mismatch Finder app that don't have an equivalent in Codex are replaced by custom variables TASK DETAIL https://phabricator.wikimedia.org/T346259 WORKBOARD https://phabricator.wikimedia.org/project/board/6016/ EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Sarai-WMDE Cc: Aklapper, Sarai-WMDE, Danny_Benjafield_WMDE, Astuthiodit_1, karapayneWMDE, Invadibot, maantietaja, Mattia_Capozzi_WMDE, ItamarWMDE, Akuckartz, Nandana, Lahi, Gq86, GoranSMilovanovic, QZanden, LawExplorer, _jensen, rosalieper, Scott_WUaS, Wikidata-bugs, aude, Mbch331
_______________________________________________ Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org
