Umherirrender closed this task as "Resolved". Umherirrender added a comment.
Thanks for the fix, the call to `RevisionRecord::getPageAsLinkTarget` is a bit depther in the stack. The title provided to the `RevisionRecord` in the old code was created by `Title::newFromRow`, that function is using columns `page_namespace` and `page_title` from the database result. The fix is using `rc_namespace` and `rc_title`. In the most cases both are identically, only on page moves both could be differ. In case of Wikibase there is no problem with that and I also see no problem for other usages on the hook (The title was added the first time in a44edf4a712ddac24dc4f58f7029febffaee3d3a <https://phabricator.wikimedia.org/rMWa44edf4a712ddac24dc4f58f7029febffaee3d3a>). TASK DETAIL https://phabricator.wikimedia.org/T348665 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Lucas_Werkmeister_WMDE, Umherirrender Cc: Lucas_Werkmeister_WMDE, Umherirrender, tstarling, Aklapper, Mahir256, Danny_Benjafield_WMDE, Astuthiodit_1, Susie413113, karapayneWMDE, Invadibot, maantietaja, ItamarWMDE, Akuckartz, Nandana, Lahi, Gq86, GoranSMilovanovic, QZanden, LawExplorer, _jensen, rosalieper, Scott_WUaS, Wong128hk, Wikidata-bugs, aude, Mbch331
_______________________________________________ Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org
