Lucas_Werkmeister_WMDE created this task. Lucas_Werkmeister_WMDE added projects: Wikidata, Wikidata Lexicographical data, wmde-wikidata-tech.
TASK DESCRIPTION As a Wikidata visitor, I want mobile page views to load quickly if possible. As an SRE, I (presumably – I’m not one) want mobile page views to not do unnecessary work, and to use cached data if available (so as to reduce server load). **Problem:** Mobile Lexeme page views never use content from the parser cache. When a parser cache entry is loaded, the parser cache runs the `onParserCacheSaveComplete` hook; Wikibase’s handler in `RepoHooks::onRejectParserCacheValue()` delegates the decision to the `TermboxVersionParserCacheValueRejector`; the rejector determines that the current page view should render a termbox (according to `TermboxFlag::shouldRenderTermbox()`), yet there’s no termbox version in the parser options, therefore the parser output should be rejected. This happens on every mobile lexeme page view. Note that this only applies when the entry is loaded from the parser cache. Afterwards, we still save an entry to the parser cache; the fact that this entry is then used for future //desktop// page views (where the rejection hook handler doesn’t apply, because desktop page views aren’t expected to have a termbox!) is what causes T344362: Some Lexemes seem to miss styles/scripts. Can be "fixed" by purging. <https://phabricator.wikimedia.org/T344362>. We’re fixing T344362 <https://phabricator.wikimedia.org/T344362> separately by splitting the parser cache, but that will still leave the issue of mobile Lexeme page views being inefficient due to not using their own cache results. **Example:** Load mobile L123 <https://m.wikidata.org/wiki/Lexeme:L123> a few times and look at the “Saved in parser cache” comment in the HTML source; you will see a different timestamp each time. (You’ll need to be logged in for this, or use WikimediaDebug <https://wikitech.wikimedia.org/wiki/WikimediaDebug>, to bypass the HTTP-level cache – that cache is still working.) **Screenshots/mockups:** **BDD** GIVEN AND WHEN AND THEN AND **Acceptance criteria:** - WikibaseLexeme page views use the parser cache as much as possible **Open questions:** TASK DETAIL https://phabricator.wikimedia.org/T348872 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Lucas_Werkmeister_WMDE Cc: Lucas_Werkmeister_WMDE, Danny_Benjafield_WMDE, Astuthiodit_1, karapayneWMDE, Invadibot, maantietaja, ItamarWMDE, Akuckartz, Nandana, Lahi, Gq86, GoranSMilovanovic, Mahir256, QZanden, LawExplorer, _jensen, rosalieper, Scott_WUaS, Wikidata-bugs, aude, Mbch331
_______________________________________________ Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org
