Sarai-WMDE added a comment.
Thanks for all the replacements! Summary of the review: - FAQ Dialog ✅ - Instructions Dialog ✅ - Upload Info Dialog (Results page): This dialog cannot currently be checked in the staging environment (no "link the full description" links are included). - Confirmation dialog (Results page): There's an improvement to make here. The "Do not show again" checkbox should be included in the footer slot provided by the Codex Dialog (see demo <https://doc.wikimedia.org/codex/main/components/demos/dialog.html#with-custom-header-and-footer>) instead of within the Dialog's body. We're still using the WiKit checkbox here, so I'm not sure if it'd make more sense to wait until said element is replaced in T347200 <https://phabricator.wikimedia.org/T347200>. F41514884: Screenshot 2023-11-18 at 06.41.29.png <https://phabricator.wikimedia.org/F41514884> TASK DETAIL https://phabricator.wikimedia.org/T347100 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: HasanAkgun_WMDE, Sarai-WMDE Cc: Arian_Bozorg, Aklapper, Michael, Sarai-WMDE, Danny_Benjafield_WMDE, Astuthiodit_1, STH, karapayneWMDE, Invadibot, maantietaja, Mattia_Capozzi_WMDE, ItamarWMDE, Akuckartz, Nandana, Lahi, Gq86, GoranSMilovanovic, QZanden, LawExplorer, _jensen, rosalieper, Scott_WUaS, Volker_E, Wikidata-bugs, aude, Lydia_Pintscher, Mbch331
_______________________________________________ Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org
