thiemowmde created this task. thiemowmde added a subscriber: thiemowmde. thiemowmde added projects: Wikidata, Wikibase-Internal-Serialization, DataValues, Performance. Restricted Application added a subscriber: Aklapper.
TASK DESCRIPTION Certain deserializers store the provided serialization in a private property for no other reason than to avoid passing it around as a function parameter. This is a problem for two reasons: 1. It makes the code error prone because methods depend on a non-obvious side effect. 2. It's a possible performance issue because it possibly clones big arrays and allocates space. Relevant classes: * `DataValueDeserializer` in the DataValues Serialization component. * Almost all deserializers in the Internal Serialization component. TASK DETAIL https://phabricator.wikimedia.org/T98124 REPLY HANDLER ACTIONS Reply to comment or attach files, or !close, !claim, !unsubscribe or !assign <username>. EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: thiemowmde Cc: thiemowmde, Aklapper, Wikidata-bugs, aude, GWicke _______________________________________________ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
