Sarai-WMDE created this task. Sarai-WMDE added projects: Wikidata Dev Team, Wikidata, Mismatch Finder.
TASK DESCRIPTION Problem ------- The Mismatch Finder's user interface was styled using WiKit tokens. With the WiKit design system being superseded by Codex, the official Wikimedia design system. The utilization of WiKit tokens is not recommended, and they should be replaced in order to reduce maintenance costs and ensure consistency. Solution -------- We have to replace all WiKit tokens used to style the Mismatch Finder app. This task focuses on the replacement of the deprecated tokens used in the project's Sass files: - _typography.scss <https://github.com/wmde/wikidata-mismatch-finder/blob/development/resources/sass/_typography.scss> - app.scss <https://github.com/wmde/wikidata-mismatch-finder/blob/development/resources/sass/app.scss> - noscript.scss <https://github.com/wmde/wikidata-mismatch-finder/blob/development/resources/sass/noscript.scss> To support the replacement, here's a WiKit to Codex tokens mapping <https://docs.google.com/spreadsheets/d/1CmrW7JVt9o2TvAfyIVScOE_Vc1h8DLpBqvsVhAB84kU/edit#gid=1602375525>. You can find the WiKit tokens matched with their corresponding Codex token. Considerations -------------- - The task's goal is to replace WiKit tokens. Nevertheless, we should consider the stretch goal of replacing discrete values too, if possible (e.g. If by any chance we fond the value #000 used for color, replace it by `$color-emphasized`). - Any WiKit component tokens used individually in the file will need to also be replaced by an equivalent Codex token. - Typographic styles are currently defined in the MSMF `app.scss` file, including WiKit mixins under each relevant selector. The assumption is that we'll replace said mixins by the relevant Codex tokens in each case, and create any missing styles (see specs included above for more details). - The current body style will be replaced by Body M. A new Body S style will be used to define the smaller text within the MSMF footer Acceptance criteria ------------------- [ ] All the WiKit tokens used in the MSMF Sass files are replaced by their Codex equivalent [ ] Potential discrete values are replaced by the equivalent Codex token TASK DETAIL https://phabricator.wikimedia.org/T352304 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Sarai-WMDE Cc: Aklapper, Sarai-WMDE, Danny_Benjafield_WMDE, Astuthiodit_1, karapayneWMDE, Invadibot, maantietaja, Mattia_Capozzi_WMDE, ItamarWMDE, Akuckartz, Nandana, Lahi, Gq86, GoranSMilovanovic, QZanden, LawExplorer, _jensen, rosalieper, Scott_WUaS, Wikidata-bugs, aude, Mbch331
_______________________________________________ Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org
