Lucas_Werkmeister_WMDE added a comment.

  The main thing we need is confirmation from @Arian_Bozorg that the change is 
okay to go ahead with, based on the screenshots I posted above. I also wanted 
to try to add a new test for this feature, but then I ran into T352695 
<https://phabricator.wikimedia.org/T352695> and have been busy with that and 
other stuff this week – that’s why I didn’t reply for a few days, sorry.
  
  If you want, you can try to extend `SpecialNewItemTest` yourself (e.g. add a 
check for the badge input(s) to 
`testSiteAndPageInputFieldsWithPredefinedValuesPresent_WhenRenderedWithGetParametersPassed()`,
 though I don’t know yet what the right assertion method is); otherwise I’ll 
see if I can get around to it next week.

TASK DETAIL
  https://phabricator.wikimedia.org/T324420

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Lucas_Werkmeister_WMDE
Cc: Arian_Bozorg, Tacsipacsi, Lucas_Werkmeister_WMDE, Oudedutchman, Aklapper, 
Stang, Ericliu1912, Bugreporter, Danny_Benjafield_WMDE, Isabelladantes1983, 
Themindcoder, Adamm71, Jersione, Hellket777, LisafBia6531, Astuthiodit_1, 786, 
Biggs657, karapayneWMDE, Invadibot, maantietaja, Juan90264, Alter-paule, 
Beast1978, ItamarWMDE, Un1tY, Akuckartz, Hook696, Kent7301, joker88john, 
CucyNoiD, Nandana, Gaboe420, lucamauri, Giuliamocci, Cpaulf30, Lahi, Gq86, 
Af420, Bsandipan, GoranSMilovanovic, QZanden, LawExplorer, Lewizho99, 
Maathavan, _jensen, rosalieper, Neuronton, Scott_WUaS, Wikidata-bugs, aude, 
Mbch331
_______________________________________________
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org

Reply via email to