Umherirrender created this task. Umherirrender added projects: MediaWiki-extensions-WikibaseRepository, PHP 8.2 support. Restricted Application added a subscriber: Aklapper.
TASK DESCRIPTION phpunit under php8.2 fails with the following message https://integration.wikimedia.org/ci/job/quibble-vendor-mysql-php82-noselenium-docker/151/console 41) Wikibase\Lib\Tests\MockRepositoryTest::testSaveEntity with data set "fresh" (Wikibase\DataModel\Entity\Item Object (...), 1, false) Creation of dynamic property Wikibase\Lib\Store\EntityRevision::$user is deprecated /workspace/src/extensions/Wikibase/lib/tests/phpunit/MockRepository.php:263 /workspace/src/extensions/Wikibase/lib/tests/phpunit/MockRepository.php:486 /workspace/src/extensions/Wikibase/lib/tests/phpunit/MockRepositoryTest.php:447 42) Wikibase\Lib\Tests\MockRepositoryTest::testSaveEntity with data set "update" (Wikibase\DataModel\Entity\Item Object (...), 2, 1011) Creation of dynamic property Wikibase\Lib\Store\EntityRevision::$user is deprecated /workspace/src/extensions/Wikibase/lib/tests/phpunit/MockRepository.php:263 /workspace/src/extensions/Wikibase/lib/tests/phpunit/MockRepository.php:486 /workspace/src/extensions/Wikibase/lib/tests/phpunit/MockRepositoryTest.php:447 43) Wikibase\Lib\Tests\MockRepositoryTest::testUpdateWatchlist Creation of dynamic property Wikibase\Lib\Store\EntityRevision::$user is deprecated /workspace/src/extensions/Wikibase/lib/tests/phpunit/MockRepository.php:263 /workspace/src/extensions/Wikibase/lib/tests/phpunit/MockRepository.php:486 /workspace/src/extensions/Wikibase/lib/tests/phpunit/MockRepositoryTest.php:585 44) Wikibase\Lib\Tests\MockRepositoryTest::testUserWasLastToEdit Creation of dynamic property Wikibase\Lib\Store\EntityRevision::$user is deprecated /workspace/src/extensions/Wikibase/lib/tests/phpunit/MockRepository.php:263 /workspace/src/extensions/Wikibase/lib/tests/phpunit/MockRepository.php:486 /workspace/src/extensions/Wikibase/lib/tests/phpunit/MockRepositoryTest.php:602 The code is: $revision = new EntityRevision( $entity->copy(), // note: always clone $revisionId, wfTimestamp( TS_MW, $timestamp ) ); if ( $user !== null ) { if ( $user instanceof UserIdentity ) { $user = $user->getName(); } // just glue the user on here... $revision->user = $user; } Not sure why it was added in 58d27b73c6fbaf99ba8e51b98f1c7837046ff723 <https://phabricator.wikimedia.org/rEWBA58d27b73c6fbaf99ba8e51b98f1c7837046ff723>, it seems the property never exists on the EntityRevision TASK DETAIL https://phabricator.wikimedia.org/T353184 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Umherirrender Cc: Aklapper, Umherirrender, malberts, ItamarWMDE, Akuckartz, lucamauri, Gq86, TK-999, Wikidata-bugs, Jdforrester-WMF
_______________________________________________ Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org
