Sarai-WMDE added a subscriber: Arian_Bozorg. Sarai-WMDE added a comment.
Hey hey. Finally reviewing this. Sorry for the delay, @noarave. Here are a couple of comments: 1. The current implementation applies the Codex link mixin styles to all <a> elements via app.scss. Nevertheless, this styling should be reserved only for text elements (or text+icon). The MSMF logo shouldn't display the link's outline when active/focused: F41600651: Screenshot 2023-12-14 at 17.41.10.png <https://phabricator.wikimedia.org/F41600651> 2. The "Log in" link displays the color #a2a9b1 in its default state (the style of all other states are fine). It appears to be inheriting it from the auth-widget div: F41600687: Screenshot 2023-12-14 at 18.04.00.png <https://phabricator.wikimedia.org/F41600687> 3. This is rather an improvement, so let's evaluate if we should capture it in a separate small task instead (att @Arian_Bozorg): It's not relevant for users to know if they have visited the "Log in", "Log out" or their user page (involuntary revisits are unlikely). The auth links don't need to display a visited state. F41600698: Screenshot 2023-12-14 at 18.15.57.png <https://phabricator.wikimedia.org/F41600698> TASK DETAIL https://phabricator.wikimedia.org/T347161 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: noarave, Sarai-WMDE Cc: Arian_Bozorg, ItamarWMDE, Aklapper, Michael, Sarai-WMDE, Danny_Benjafield_WMDE, Astuthiodit_1, STH, karapayneWMDE, Invadibot, maantietaja, Mattia_Capozzi_WMDE, Akuckartz, Nandana, Lahi, Gq86, GoranSMilovanovic, QZanden, LawExplorer, _jensen, rosalieper, Scott_WUaS, Volker_E, Wikidata-bugs, aude, Lydia_Pintscher, Mbch331
_______________________________________________ Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org
