DAlangi_WMF added a comment.
In T350806#9410485 <https://phabricator.wikimedia.org/T350806#9410485>, @matmarex wrote: > As discovered above, Wikibase (and CommonsMetadata too) actually use the ContentHandler::getPageViewLanguage rather than Title::getPageViewLanguage. I'm not sure if it was intended to be in scope for this task? It's similarly bad and indirectly reads from global state in the same way. I can confirm that CommonsMetadata and Wikibase are not in scope for this task. In fact, I did a patch first for Wikibase and we ended up realizing that it's not in scope and I just verified CommonsMetadata as well. It calls `getPageViewLanguage()` on ContentHandler instead of Title: https://gerrit.wikimedia.org/g/mediawiki/extensions/CommonsMetadata/+/92d3152feb3148322c41aef1187842082b967a92/src/HookHandler.php#155 TASK DETAIL https://phabricator.wikimedia.org/T350806 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: DAlangi_WMF Cc: xSavitar, Tgr, WMDE-leszek, Michael, matmarex, Aklapper, Krinkle, Danny_Benjafield_WMDE, Mohamed-Awnallah, mrephabricator, LennardHofmann, Astuthiodit_1, lbowmaker, BTullis, karapayneWMDE, toberto, Invadibot, Ywats0ns, caldera, maantietaja, NavinRizwi, CBogen, ItamarWMDE, Akuckartz, 94rain, Nandana, lucamauri, Patriccck, Lahi, Gq86, Ramsey-WMF, GoranSMilovanovic, TJH2018, Nattes, QZanden, EnricoCNC, LawExplorer, SundanceRaphael, _jensen, rosalieper, Taiwania_Justo, Scott_WUaS, Izno, alex-mashin, Wikidata-bugs, aude, geraki, Dinoguy1000, Gryllida, jeblad, jayvdb, MrStradivarius, Tacsipacsi, Catrope, Jackmcbarn, Mbch331
_______________________________________________ Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org